- Issue created by @manpreet_singh
- Assigned to nitin_lama
- š®š³India nitin_lama India
Two warnings remaining. Please review.
FILE: /home/system/Documents/contribution/book_navigation_block-3403917/src/Plugin/Block/BookNavigationBlock.php ---------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------- 83 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 123 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ----------------------------------------------------------------------------------------------------------------
- Issue was unassigned.
- Status changed to Needs work
about 1 year ago 8:17am 24 November 2023 - Status changed to Needs review
about 1 year ago 1:20pm 29 November 2023 All the issues reported by PHPcs has been fixed in attached patch.
Please review
Thank you- Status changed to RTBC
about 1 year ago 2:59am 1 December 2023 - šµšPhilippines clarkssquared
Hi
I applied patch #6 and I confirmed that it fixes all the PHPCS issues the remaining issues that my terminal flagged occurs when the module is installed via composer.
ā book_navigation_block git:(master) ā curl https://www.drupal.org/files/issues/2023-11-29/fixed_phpcs_issues.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 6853 100 6853 0 0 13382 0 --:--:-- --:--:-- --:--:-- 13816 patching file book_navigation_block.module patching file 'src/Plugin/Block/BookNavigationBlock.php' ā book_navigation_block git:(master) ā .. ā contrib git:(master) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml book_navigation_block FILE: ...jects/d9/d9-local/web/modules/contrib/book_navigation_block/book_navigation_block.info.yml ------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------ 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging | | automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging | | automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging | | automatically 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ------------------------------------------------------------------------------------------------ Time: 555ms; Memory: 10MB ā contrib git:(master) ā