- Issue created by @sunil_lnwebworks
- Assigned to pray_12
- 🇮🇳India pray_12
Hi,
Reviewed the patch. There are many errors and warnings pending that need to be resolved.
I will work on this issue. - Issue was unassigned.
- 🇮🇳India pray_12
Fixed few errors and warnings.
There are few warnings and errors need to be solved.FILE: .../twilio_otp_login/twilio_otp_login.module ---------------------------------------------------------------------------- FOUND 9 ERRORS AND 6 WARNINGS AFFECTING 13 LINES ---------------------------------------------------------------------------- 3 | ERROR | Missing short description in doc comment 14 | WARNING | Hook implementations should not duplicate @param | | documentation 16 | WARNING | Hook implementations should not duplicate @param | | documentation 16 | ERROR | Doc comment for parameter $form_state does not match | | actual variable name $form_id 18 | WARNING | Hook implementations should not duplicate @param | | documentation 23 | WARNING | Line exceeds 80 characters; contains 85 characters 30 | ERROR | The array declaration extends to column 307 (the limit is | | 80). The array content should be split up over multiple | | lines 38 | ERROR | Doc comment is empty 41 | ERROR | Invalid function name, expected validate_mobile but found | | validateMobile 41 | ERROR | All functions defined in a module file must be prefixed | | with the module's name, found "validateMobile" but | | expected "twilio_otp_login_validateMobile" 97 | ERROR | Doc comment short description must end with a full stop 99 | WARNING | Line exceeds 80 characters; contains 109 characters 101 | WARNING | Line exceeds 80 characters; contains 85 characters 127 | ERROR | Doc comment is empty 130 | ERROR | All functions defined in a module file must be prefixed | | with the module's name, found "phone_login_callback" but | | expected "twilio_otp_login_phone_login_callback" ---------------------------------------------------------------------------- FILE: .../twilio_otp_login/css/otp.css ---------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------- 1 | ERROR | [x] Additional whitespace found at start of file ---------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------
- Status changed to Needs review
8 months ago 9:01am 23 March 2024 - Merge request !1Issue #3427820: Fix the errors/warnings reported by PHP_CodeSniffer → (Open) created by apaderno