Fix the PHP_CodeSniffer issues reported by GitLab CI

Created on 14 March 2024, 3 months ago
Updated 23 March 2024, 3 months ago
📌 Task
Status

Needs review

Version

1.0

Component

Code

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @sunil_lnwebworks
  • 🇮🇳India viren18febS

    I have added a patch for this.

  • Assigned to Preethy_ray
  • 🇮🇳India Preethy_ray

    Hi,
    Reviewed the patch. There are many errors and warnings pending that need to be resolved.
    I will work on this issue.

  • Issue was unassigned.
  • 🇮🇳India Preethy_ray

    Fixed few errors and warnings.
    There are few warnings and errors need to be solved.

    FILE: .../twilio_otp_login/twilio_otp_login.module
    ----------------------------------------------------------------------------
    FOUND 9 ERRORS AND 6 WARNINGS AFFECTING 13 LINES
    ----------------------------------------------------------------------------
       3 | ERROR   | Missing short description in doc comment
      14 | WARNING | Hook implementations should not duplicate @param
         |         | documentation
      16 | WARNING | Hook implementations should not duplicate @param
         |         | documentation
      16 | ERROR   | Doc comment for parameter $form_state does not match
         |         | actual variable name $form_id
      18 | WARNING | Hook implementations should not duplicate @param
         |         | documentation
      23 | WARNING | Line exceeds 80 characters; contains 85 characters
      30 | ERROR   | The array declaration extends to column 307 (the limit is
         |         | 80). The array content should be split up over multiple
         |         | lines
      38 | ERROR   | Doc comment is empty
      41 | ERROR   | Invalid function name, expected validate_mobile but found
         |         | validateMobile
      41 | ERROR   | All functions defined in a module file must be prefixed
         |         | with the module's name, found "validateMobile" but
         |         | expected "twilio_otp_login_validateMobile"
      97 | ERROR   | Doc comment short description must end with a full stop
      99 | WARNING | Line exceeds 80 characters; contains 109 characters
     101 | WARNING | Line exceeds 80 characters; contains 85 characters
     127 | ERROR   | Doc comment is empty
     130 | ERROR   | All functions defined in a module file must be prefixed
         |         | with the module's name, found "phone_login_callback" but
         |         | expected "twilio_otp_login_phone_login_callback"
    ----------------------------------------------------------------------------
    
    
    FILE: .../twilio_otp_login/css/otp.css
    ----------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ----------------------------------------------------------------------------
     1 | ERROR | [x] Additional whitespace found at start of file
    ----------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------------
    
  • Status changed to Needs review 3 months ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
  • Pipeline finished with Success
    3 months ago
    Total: 143s
    #126914
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
Production build 0.69.0 2024