[1.0.x] Menu Item Group Role Access

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

1. FILE: menu_item_group_role_access.module

/**
 * @file
 * Menu Item Group Role Access module.
 */

The description for a module is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.

2. FILE: src/MenuItemRoleAccessLinkTreeManipulator.php

  public function __construct(AccessManagerInterface $access_manager,
  AccountInterface $account,
  EntityTypeManagerInterface $entity_type_manager,
  ConfigManagerInterface $config_manager,
  EntityRepositoryInterface $entity_repository,
  ) {

Function and method declarations are written on a single line.

@vishal.kadam

Function and method declarations are allowed to span multiple lines under the Drupal PHP Coding Standards.

Please ensure you are referring the latest copy of the Drupal Coding Standards to avoid creating unnecessary work and delay for maintainers.

Actually, neither #3392321: Relax the "Conditions should not be wrapped into multiple lines" rule for more code readability → nor #3295249: Allow multi-line function declarations → are marked fixed. The coding standards are still saying that function declarations must be written on a single line.

@apaderno

https://www.drupal.org/docs/develop/standards/php/php-coding-standards#f... →

Argument lists may be split across multiple lines, where each subsequent line is indented once.

Approved for committing to the official code standards documentation in #3295249: Allow multi-line function declarations → . That issue may need a status change, I've pinged them for their comment to update.

Hi @all

I had the necessary code review fixes, as per your suggestion could you please review it.

The guidelines → state that Critical is for issues 8 weeks or older.

Thank you for your contribution!
I updated your account so you can now opt into security advisory coverage for any project you created and every project you will create.

These are some recommended readings to help you with maintainership:

• Dries → ' post on Responsible maintainers
• Maintainership →
• Git version control system →
• Issue procedures and etiquette →
• Maintaining and responding to issues for a project →
• Release naming conventions → .

You can find more contributors chatting on Slack → or IRC → in #drupal-contribute. So, come hang out and stay involved → !

Thank you for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank also the dedicated reviewers as well.

Automatically closed - issue fixed for 2 weeks with no activity.