- Status changed to Needs work
about 1 year ago 4:04pm 13 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command and arguments have been used, and which report that command shown.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Since there have been recent commits, the provided patch needs to be re-rolled.
- Assigned to nitin_lama
- last update
about 1 year ago 1 pass - @nitin_lama opened merge request.
- 🇮🇳India nitin_lama
Only one issues left. Not sure how to fix this.
FILE: /home/system/Documents/contribution/views_custom_cache_tag-2997382/tests/src/Functional/CustomCacheTagsTest.php --------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------- 243 | ERROR | Parameter tags must be grouped together in a doc comment --------------------------------------------------------------------------------------------------------------------- Time: 54ms; Memory: 10MB
- Issue was unassigned.
- Assigned to Shanu Chouhan
- Status changed to Active
about 1 year ago 10:58am 15 May 2023 - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 11:55am 15 May 2023 - last update
about 1 year ago 1 pass - 🇮🇳India Shanu Chouhan
I have Fixed This issue 243 | ERROR | Parameter tags must be grouped together in a doc comment.
- Status changed to Needs work
about 1 year ago 2:02pm 15 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The last patch is not complete, since it does not fix all the warnings/errors reported in the issue summary.
- Assigned to kbk1992
- last update
about 1 year ago 1 pass - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 2:46pm 15 May 2023 - last update
about 1 year ago Patch Failed to Apply - Status changed to Needs work
about 1 year ago 3:56pm 15 May 2023 - Status changed to Needs review
about 1 year ago 5:32pm 15 May 2023 - last update
about 1 year ago 1 pass - Assigned to arpitk
- Issue was unassigned.
- Status changed to RTBC
about 1 year ago 6:06pm 15 May 2023 - 🇮🇳India arpitk
Hi I am able to apply the patch #31 cleanly. After applying the patch no errors are produced anymore. I tested on Drupal 9.5.8 and 8.x-1.x-dev. Using commands phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig
Moving the status to RTBC
Thanks!
- Status changed to Needs work
about 1 year ago 8:56pm 15 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
dependencies: - - views_custom_cache_tag - - node - - menu_ui - - views - - rest - - serialization + - drupal:views_custom_cache_tag + - drupal:node + - drupal:menu_ui + - drupal:views + - drupal:rest + - drupal:serialization
The Views Custom Cache Tags → module (this very module) is not a Drupal core module.
/** /** - * Overrides Drupal\views\Plugin\Plugin::$usesOptions. + * Overide view plugin. + * + * @var Drupal\views\Plugin\PluginusesOptions */ protected $usesOptions = TRUE;
Overrides is not used in Drupal document comments and the changed description does not match with what the existing description says. Probably
{@inheritdoc}
is sufficient.
Drupal\views\Plugin\PluginusesOptions
is not that property's type. (Since its default value isTRUE
, that should help in understanding the correct value.) - Status changed to Needs review
about 1 year ago 6:34am 16 May 2023 - last update
about 1 year ago 1 pass Hi, Reviewed the patch at #36 applies cleanly and resolves all the phpcs error/warnings and also addresses the comments at #35