- Issue created by @Diksha Singhal
Hi @Junaid
I have added Readme.md file for this module.
Please review it once.
Thank You !!
- Status changed to Needs review
over 1 year ago 10:55am 10 January 2024 - Status changed to Needs work
over 1 year ago 6:26am 11 January 2024 - 🇵🇭Philippines kenyoOwen
I reviewed your changes and it doesn't follow the README.md template. → .
Thank you
- Status changed to Needs review
over 1 year ago 10:33am 11 January 2024 - Status changed to Needs work
over 1 year ago 11:24am 11 January 2024 - thakurnishant_06 India
Please update the readme file in markdown format as per the recommended drupal readme.md template.
- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 12:45pm 11 January 2024 - Status changed to Needs work
over 1 year ago 7:41am 16 January 2024 - 🇮🇳India Nupur Badola
Reviewed MR!1, the patch is not cleanly applied.
Please follow the instruction mentioned on https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... → - 🇮🇳India dev16.addweb
Hi, I have reviewed MR and it has been applied cleanly,
www-data@e137cbd96b5e:/app/web/modules/custom$ git clone https://git.drupalcode.org/project/fullcalendar_dynamic.git Cloning into 'fullcalendar_dynamic'... cd fullca remote: Enumerating objects: 182, done. remote: Counting objects: 100% (8/8), done. remote: Compressing objects: 100% (7/7), done. remote: Total 182 (delta 0), reused 0 (delta 0), pack-reused 174 Receiving objects: 100% (182/182), 55.17 KiB | 1.90 MiB/s, done. Resolving deltas: 100% (82/82), done. www-data@e137cbd96b5e:/app/web/modules/custom$ cd fullcalendar_dynamic/ www-data@e137cbd96b5e:/app/web/modules/custom/fullcalendar_dynamic$ git branch * 1.x www-data@e137cbd96b5e:/app/web/modules/custom/fullcalendar_dynamic$ curl https://git.drupalcode.org/project/fullcalendar_dynamic/-/merge_requests/1.diff |git apply -v % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1190 0 1190 0 0 316 0 --:--:-- 0:00:03 --:--:-- 316 Checking patch README.md... Applied patch README.md cleanly.
- Status changed to Needs review
10 months ago 6:18am 27 June 2024 - Status changed to Needs work
10 months ago 4:47am 28 June 2024 - 🇵🇭Philippines kenyoOwen
Hi silvi.addweb
I reviewed the MR!1 and it seems the TOC isn't following README.md template.
This should be the format of TOC as per README.md template:## Table of contents - Requirements - Recommended modules - Installation - Configuration - Troubleshooting - FAQ - Maintainers
Thanks
- Status changed to Needs review
10 months ago 10:35am 28 June 2024 - Status changed to RTBC
10 months ago 6:40am 1 July 2024 - 🇵🇭Philippines kenyoOwen
Hi silvi.addweb
I reviewed your changes and it fixed the comment #14. The README.md file is now following the README.md template. https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or-distribution-project/documenting-your-project/readmemd-template →
Thanks.