- First commit to issue fork.
- @vishaljd opened merge request.
- Issue was unassigned.
- Status changed to Needs review
about 2 years ago 9:59am 22 February 2023 - Status changed to Needs work
about 2 years ago 1:39pm 22 February 2023 - 🇮🇳India dev20.addweb
yoftahe.addweb → made their first commit to this issue’s fork.
- Merge request !3Issue #3320321 : Optimizing Code According to Drupal Coding Standard and Fixing Indentation → (Open) created by Unnamed author
- Status changed to Needs review
10 months ago 8:07am 14 May 2024 - Assigned to dev16.addweb
- Status changed to Needs work
8 months ago 6:01am 9 July 2024 - 🇮🇳India dev16.addweb
Hello,
Although my test MR!3 applied successfully, I discovered a few new issues and warnings, which I have listed below.
FILE: /home/addweb/Drupal8-vagrant/web/web/drupal8_9/web/modules/contrib/clockify_report/README.md -------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------------------------- 13 | WARNING | Line exceeds 80 characters; contains 134 characters -------------------------------------------------------------------------------------------------- FILE: /home/addweb/Drupal8-vagrant/web/web/drupal8_9/web/modules/contrib/clockify_report/clockify_report.info.yml ----------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES ----------------------------------------------------------------------------------------------------------------- 1 | WARNING | "core_version_requirement" property is missing in the info.yml file 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 9 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ----------------------------------------------------------------------------------------------------------------- FILE: /home/addweb/Drupal8-vagrant/web/web/drupal8_9/web/modules/contrib/clockify_report/clockify_report.module --------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES --------------------------------------------------------------------------------------------------------------- 98 | WARNING | Unused variable $split_week. 175 | WARNING | Unused variable $array. 289 | WARNING | Unused variable $weekday_name. 471 | WARNING | Unused variable $key. 483 | WARNING | Unused variable $key. 504 | WARNING | Unused variable $weekday_name. 687 | WARNING | Unused variable $key. --------------------------------------------------------------------------------------------------------------- FILE: /home/addweb/Drupal8-vagrant/web/web/drupal8_9/web/modules/contrib/clockify_report/templates/invoice-download.html.twig ----------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------- 3 | ERROR | [x] Expected 1 newline at end of file; 0 found ----------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------- - Issue was unassigned.
- Assigned to dev2.addweb
- Issue was unassigned.
- Status changed to Needs review
8 months ago 6:48am 9 July 2024 - 🇮🇳India dev2.addweb
All of the issues and warnings mentioned above have been resolved. Also raised MR ! 4 for the same.
- Merge request !5Issue #3320321: Optimizing Code According to Drupal Coding Standard and Fixing Indentation → (Merged) created by apaderno
- 🇮🇹Italy apaderno Brescia, 🇮🇹
apaderno → changed the visibility of the branch coding_standard to hidden.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
apaderno → changed the visibility of the branch 3320321-optimizing-code-according to hidden.
- Status changed to RTBC
8 months ago 4:28pm 9 July 2024 - 🇮🇹Italy apaderno Brescia, 🇮🇹
All the reported PHP_CodeSniffer errors/warnings have been fixed.
- Status changed to Fixed
8 months ago 12:57pm 11 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.