Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 16 June 2022, about 2 years ago
Updated 10 February 2023, over 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • First commit to issue fork.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇦🇺Australia Deciphered

    Updated MR and Patch, should now be passing tests.

  • @deciphered opened merge request.
  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇦🇺Australia Deciphered

    It appears that the JSON:API Views exposed sorts provides a different result in Drupal 10, causing the tests to fail.

    Further investigation / work required.

  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇧🇾Belarus e.bogatyrev

    Hi everyone,

    I checked out the branch 3288151-automated-drupal-10, verified compatibility and discovered the following after scanning issues by the upgrade_status module
    drush upgrade_status:analyze jsonapi_views

    ================================================================================
JSON:API Views, --
Scanned on Fri, 02/10/2023 - 01:52

FILE: web/modules/contrib/jsonapi_views/jsonapi_views.info.yml

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8.8 || ^9 || ^10 is not
                    compatible with the next major version of Drupal core. See
                    https://drupal.org/node/3070687.
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/jsonapi_views/tests/modules/jsonapi_views_test/jsonapi_views
_test.info.yml

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8.8 || ^9 || ^10 is not
                    compatible with the next major version of Drupal core. See
                    https://drupal.org/node/3070687.
--------------------------------------------------------------------------------

FILE: web/modules/contrib/jsonapi_views/composer.json

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 0    The drupal/core requirement is not compatible with the next
                    major version of Drupal. Either remove it or update it to be
                    compatible. See
                    https://drupal.org/node/2514612#s-drupal-9-compatibility.
--------------------------------------------------------------------------------

    Apart from this I verified the tests. The issue is related to missed parameter (field_identifier: nid) in test view views.view.jsonapi_views_test_node_view.yml

    After applying the patch

    Compatibility check

    ================================================================================
JSON:API Views, --
Scanned on Fri, 02/10/2023 - 01:54

No known issues found.

    Tests run

    PHPUnit 9.6.3 by Sebastian Bergmann and contributors.

Testing Drupal\Tests\jsonapi_views\Functional\JsonapiViewsResourceTest
......                                                              6 / 6 (100%)

Time: 01:40.078, Memory: 10.00 MB

OK (6 tests, 180 assertions)

    Please review the patch.

  • Comment over 1 year ago →
    🇦🇺Australia Deciphered

    Thanks @e.bogatyrev, that looks great, I'll run a few manual tests, but this looks like it should be good to go for a merge and release.

  • Status changed to RTBC over 1 year ago
  • Comment over 1 year ago →
    🇦🇺Australia Deciphered

    RTBC, thanks everyone

  • Comment over 1 year ago →
    System Message
    • Deciphered → committed d820f708 on 8.x-1.x 
      Issue #3288151 by Project Update Bot, reenaraghavan, Deciphered,...
  • Status changed to Fixed over 1 year ago
  • Comment over 1 year ago →
    🇦🇺Australia Deciphered
  • Comment over 1 year ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024