Update throbber icon

Regarding why this was marked postponed, ✨ Update throbber icon Needs work is dead. The Seven theme has been removed from Drupal 10 core.

I see Olivero now has a custom throbber.svg but it is not a 1-to-1 against the old original throbber GIF.

On this issue's sister issue 📌 Update loading icon and use SVG Needs review , after flailing about for a long time, the consensus became to reduce scope and get to RTBC by making the replacement a 1-to-1 (same size, color and speed). I think it makes sense to do exactly the same thing here.

The old throbber-active.gif is still referenced in core by stable9 as well as core's default ajax-progress and autocomplete-loading CSS files, so there is good reason to get this updated.

I put together a codepen to compare side-by-side before/after with a fairly close 1-to-1 (speed, color, size) though the style is slightly different, and modernized.

https://codepen.io/jameswilson/pen/LYoZaXy

The SVG needs to be updated to use svg instead of css keyfram animation, a minor detail though.

I prefer the original throbber (SVG rendered). It looks like a single-hand clock.

The main question being, though, can the themer change the throbber color or better yet, use her or his own SVG file?

can the themer change the throbber color or better yet, use her or his own SVG file?

Yes! This is actually one of the primary reasons this issue was postponed some time ago: i.e., in order to create an overridden/custom throbber in another core theme.

See #118 point 2.3

I prefer the original throbber (SVG rendered). It looks like a single-hand clock.

👍. I actually feel the same. Now that it is fairly easy for themers to override the throbber and we have an example in core already, it may be less contentious to leave the existing design as a nod to the past and a relic of our roots, as well as just a simple fact of getting to RTBC sooner.

MR appears to have test failures.

Also believe issue summary is still relevant as the current summary mentions updating bartik

I've restarted the pipeline. The test failures seem unrelated:

Drupal\Tests\node\Functional\NodeTranslationUITest             0 passes   1 fails  

    Drupal\Tests\node\Functional\NodeTranslationUITest::testSearchIndexRebuildOnTranslationDeletion
    Behat\Mink\Exception\ResponseTextException: The text "There are 0 items
    left to index." was not found anywhere in the text of the current page.

Updating issue title to distinguish it from the other issue now moved to Seven theme queue: ✨ Update throbber icon Needs work

That failure shows it needs a rebase. That issue was fixed last week

Rebased

Okay, I've found a valid failing test having to do with htaccess scaffold file changes ...

There was 1 failure:
    
    1) Drupal\Tests\ComposerIntegrationTest::testExpectedScaffoldFiles with
    data set #6 ('.htaccess', 'assets/scaffold/files/htaccess')
    Scaffold source and destination files must have the same contents.
    Failed asserting that two strings are equal.
    --- Expected
    +++ Actual
    @@ @@
       # Rewrite install.php during installation to see if mod_rewrite is
    working\n
       RewriteRule ^core/install\.php core/install.php?rewrite=ok [QSA,L]\n
     \n
    +  # Redirect deprecated throbbers to their SVG equivalents.\n
    +  RewriteRule ^core/misc/throbber-active\.gif$
    core/misc/throbber-active.svg [L,R=301]\n
    +  RewriteRule ^core/misc/throbber-inactive\.png$
    core/misc/throbber-inactive.svg [L,R=301]\n
    +\n
       # Pass all requests not referring directly to files in the filesystem
    to\n
       # index.php.\n
       RewriteCond %{REQUEST_FILENAME} !-f\n
    
    /builds/issue/drupal-1974928/core/tests/Drupal/Tests/ComposerIntegrationTest.php:204
    
    FAILURES!
    Tests: 60, Assertions: 421, Failures: 1, Skipped: 1.

Hiding attachments from previous approaches.

Yay. tests are passing now.

I've reorganized Remaining Tasks in issue summary.

• Moved some items from Proposed Resolution section into Remaining Tasks as Complete. These tasks are technically no longer part of the proposal and were handled elsewhere.
• Added a step to copy issue credits from folks who worked on ✨ Update throbber icon Needs work that was split out from this issue while Seven theme was still in core.

I've restored the legacy throbber GIF and PNG files, per @smustgrave's comment #72 on sister ticket #2575253-72: Update loading icon and use SVG → :

there is no mechanism for deprecating images so can only remove in a major (D12). So will need to add those images back and a CR in this ticket about the images being removed in 12

I suppose this needs a CR now, but leaving in NR for adtl code review and #frontend signoff before diving deep into CR world.

I've added this issue to the list on 📌 [12.x] Remove images that have been replaced in core Active .

Wasn't ignoring this way but wanted to see how the related one was handled. Can we revert the htaccess change here as well.

Will keep an eye out for this one.

Mithun S → made their first commit to this issue’s fork.

Updated the PR with the changes as per the #162, Please review.

changes removed

Committed 6aa443c and pushed to 11.x. Thanks!

nod_ → closed merge request !8172

Refer to the issue tag guidelines → .

Automatically closed - issue fixed for 2 weeks with no activity.

xjm → credited effulgentsia → .

Belatedly adding discussion credits per #97 and #118.