Modal popups in views is not showing properly when toolbar tray is upon modal

Created on 28 October 2016, about 8 years ago
Updated 5 June 2024, 6 months ago

Steps to reproduce:
1) Set the admin theme to Stark
2) Set toolbar tray in vertical orientation.
3) Edit any view eg: www.example.org/admin/structure/views/view/content.
4) Click on any link on view page which will open in modal popup. Eg: click on settings under format.

Views modal popup in vertical toolbar orientation

🐛 Bug report
Status

Needs work

Version

11.0 🔥

Component
Toolbar 

Last updated about 7 hours ago

  • Maintained by
  • 🇫🇷France @nod_
Created by

🇮🇳India shashikant_chauhan

Live updates comments and jobs are added and updated live.
  • Usability

    Makes Drupal easier to use. Preferred over UX, D7UX, etc.

  • CSS

    It involves the content or handling of Cascading Style Sheets.

  • Accessibility

    It affects the ability of people with disabilities or special needs (such as blindness or color-blindness) to use Drupal.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇺🇸United States bnjmnm Ann Arbor, MI

    This looks to work in Claro just fine , but this is still an issue with default CSS (using the Stark theme). Seems like it would be safe to assume a themer would want the modal to appear in front of the tray, and addressing this could make creating custom admin themes a little easier.

  • 🇺🇸United States bnjmnm Ann Arbor, MI

    Re #123 @shobhit_juyal Your "no issue found" is a screenshot of Claro. If you look at the comment just prior to yours, I already confirmed this is not a problem in Claro. We need no further confirmation of that, and saying "no issue found" when you didn't check for the diagnosed issue creates confusion.

    The problem is specific to Stark AKA the default theme implementation of views. It will not happen with Claro.

  • 🇮🇳India shobhit_juyal New Delhi

    @bnjmnm, I apologize for any inconvenience caused.
    In stark theme, if we can just add z-index says 1260 then it will also work. like this:
    z-index: 1260;

    and here its UI after that update.

    Hope, if this can help.

  • 🇮🇳India pradipmodh13 Ahmedabad

    Hello @bnjmnm,
    Yes, you are correct. The ui-dialog box will be hidden on the vertical toolbar for default theme stark.
    To resolve this issue, I added a z-index to the ui-dialog box using js and verified that it works properly with all of the themes listed below.
    - Default Theme / Stark
    - Olivero
    - Bartik
    - Seven
    - Claro
    I've included a screenshot for reference.
    Please let me know if there's anything I can do better.

  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    Custom Commands Failed
  • 🇮🇳India pradipmodh13 Ahmedabad

    Fixed #126 CCF.

  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    Custom Commands Failed
  • 🇮🇳India pradipmodh13 Ahmedabad

    Fixed #127 CCF.

  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    Custom Commands Failed
  • 🇮🇳India pradipmodh13 Ahmedabad

    Fixed #126 CCF

    Note:
    Please Ignore my patch #127 and #128.

  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    Custom Commands Failed
  • 🇮🇳India pradipmodh13 Ahmedabad

    Fixed #126 CCF

    Note:
    Please Ignore my patch #127, #128 and #129

  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    30,305 pass, 4 fail
  • 🇺🇸United States bnjmnm Ann Arbor, MI

    @pradipmodh13
    You can check for Custom Commands Failed locally without having to add noise to
    the issue. At the end of the fail report there are instructions on how to do this, but they can be easy to miss.

    Drupal code quality checks failed.
    To reproduce this output locally:
    * Apply the change as a patch
    * Run this command locally: sh ./core/scripts/dev/commit-code-check.sh
    OR:
    * From the merge request branch
    * Run this command locally: sh ./core/scripts/dev/commit-code-check.sh --branch 10.1.x
    

    The occasional "Custom Commands Failed" patch is bound to happen from time to time, but first checking locally can help prevent having it occur in multiple consecutive comments.

  • 🇨🇦Canada mgifford Ottawa, Ontario

    Tagging

  • First commit to issue fork.
  • Status changed to Needs review 6 months ago
  • 🇮🇳India gauravvvv Delhi, India
  • Pipeline finished with Failed
    6 months ago
    Total: 557s
    #186705
  • Status changed to Needs work 6 months ago
  • 🇺🇸United States smustgrave

    Issue summary still appears to be needed

    Did not review or test.

Production build 0.71.5 2024