๐Ÿ‡ฎ๐Ÿ‡ณIndia @shobhit_juyal

New Delhi
Account created on 28 November 2013, over 10 years ago
#

Merge Requests

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia shobhit_juyal New Delhi

shobhit_juyal โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia shobhit_juyal New Delhi

shobhit_juyal โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia shobhit_juyal New Delhi

The changes made in the MR are sufficient to understand. closing this issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia shobhit_juyal New Delhi

This issue came again in latest branch 8.x-2.5

๐Ÿ‡ฎ๐Ÿ‡ณIndia shobhit_juyal New Delhi

I believe the issue raised by @gwvoigt is not actually related with the CKEDITOR5 compatibility, rather it should be open in a separate issue queue for the logical issue.
Please share the issue link if it has opened already.

Thanks

๐Ÿ‡ฎ๐Ÿ‡ณIndia shobhit_juyal New Delhi

Yes, not working for me as well, followed @longwave suggestion to run it from top level.

Drupal version   : 10.0.0
PHPUnit 10.5.3 by Sebastian Bergmann and contributors.

๐Ÿ‡ฎ๐Ÿ‡ณIndia shobhit_juyal New Delhi

Looks good, thanks for the commit.

๐Ÿ‡ฎ๐Ÿ‡ณIndia shobhit_juyal New Delhi

Sharing the patch

๐Ÿ‡ฎ๐Ÿ‡ณIndia shobhit_juyal New Delhi

Adding new patch as further issues detected.

๐Ÿ‡ฎ๐Ÿ‡ณIndia shobhit_juyal New Delhi

Providing patch 3398770-giella_was_not_found-2.patch

๐Ÿ‡ฎ๐Ÿ‡ณIndia shobhit_juyal New Delhi

Hi,

I faced the same issue and added a patch for it. Kindly review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia shobhit_juyal New Delhi

The same issue was coming in bp-accordion and patch suggested in #22 is fixing that issue as well.

๐Ÿ‡ฎ๐Ÿ‡ณIndia shobhit_juyal New Delhi

Patch is not applying on Drupal v. 10.1.0

Changing status to Active

๐Ÿ‡ฎ๐Ÿ‡ณIndia shobhit_juyal New Delhi

3102249-port-for-D9.3.22-63.patch

Patch failed for Drupal 10.1.0

๐Ÿ‡ฎ๐Ÿ‡ณIndia shobhit_juyal New Delhi

Patch is tested and working fine for me and #6. Drupal version - 10.1.0

Moving this to RTBC.

Thanks
mrcdrx

๐Ÿ‡ฎ๐Ÿ‡ณIndia shobhit_juyal New Delhi

Hi,

Please correct my understanding, wheather this Drupal 10 compatibility fix should not also consider the dependecies in composer.json as well.
This module has a dependency on captcha module which already has compatible Drupal 10 branch but that is not updated in this module's info file.

๐Ÿ‡ฎ๐Ÿ‡ณIndia shobhit_juyal New Delhi

The changes are working fine and fixed this issue:

I tested it on Drupal - 10.1.0-dev.

๐Ÿ‡ฎ๐Ÿ‡ณIndia shobhit_juyal New Delhi

Hi @Chris64,

Further should we exclude drupal.message library as well ?

๐Ÿ‡ฎ๐Ÿ‡ณIndia shobhit_juyal New Delhi

My apologies for the delay in responding. Your patience is appreciated.

Yes, you are right about the issue. The module installation was not properly done on that moment (might be some other issues) and after that I was facing that error. Later I thought that if it has occurred then it should be handled and hence I created this issue.

Please close this if it should.

๐Ÿ‡ฎ๐Ÿ‡ณIndia shobhit_juyal New Delhi

@bnjmnm, I apologize for any inconvenience caused.
In stark theme, if we can just add z-index says 1260 then it will also work. like this:
z-index: 1260;

and here its UI after that update.

Hope, if this can help.

๐Ÿ‡ฎ๐Ÿ‡ณIndia shobhit_juyal New Delhi

shobhit_juyal โ†’ created an issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia shobhit_juyal New Delhi

3047392-17 - Patch is skipping -

Production build 0.69.0 2024