Not compatible with D8, <D9.1; EventDispatcher::dispatch()

attaching patch

Adding new patch as further issues detected.

Added MR. Also uploading patch from diff.

Patch in #7 fixes the issue for D9.
Newest MR and patch attached in this comment fixes the issue for D10.

D10 doesn't need fixing. My mistake. Closing irrelevant MR.

vensires → closed merge request !17

This means the module should really be:

core_version_requirement: ^9.1 || ^10

Due to the change in EventDispatcher::dispatch().

Change notice: Symfony Event class deprecated, EventDispatcher::dispatch() argument order changed →

Apologies for hijacking the issue but this seems to be the real crux of the problem.

No, you are correct @elc. But this is something that can't be fixed with a patch. The module maintainers will have to decide what to do with the versioning based on the dependencies. But I believe that since D9 is EOL as of previous month (November 1st), one of the two patches should still stay visible.

Should be able to get away with the MR patch which is identical to #3, #7 and #10.

https://git.drupalcode.org/project/commerce_stock/-/merge_requests/16.diff

Updated issue summary.

I committed a change to the info file requiring a version greater than 9.1. Anyone using 8 should use the patch above.

Automatically closed - issue fixed for 2 weeks with no activity.