- Issue created by @shobhit_juyal
- last update
8 months ago Composer error. Unable to continue. - First commit to issue fork.
- last update
7 months ago 6 pass, 18 fail - Status changed to Needs review
7 months ago 9:21am 1 December 2023 - last update
7 months ago 21 pass, 12 fail - 🇬🇷Greece vensires
Patch in #7 fixes the issue for D9.
Newest MR and patch attached in this comment fixes the issue for D10. - last update
7 months ago 6 pass, 18 fail - 🇬🇷Greece vensires
D10 doesn't need fixing. My mistake. Closing irrelevant MR.
- 🇦🇺Australia ELC
This means the module should really be:
core_version_requirement: ^9.1 || ^10Due to the change in EventDispatcher::dispatch().
Change notice: Symfony Event class deprecated, EventDispatcher::dispatch() argument order changed →
Apologies for hijacking the issue but this seems to be the real crux of the problem.
- 🇬🇷Greece vensires
No, you are correct @elc. But this is something that can't be fixed with a patch. The module maintainers will have to decide what to do with the versioning based on the dependencies. But I believe that since D9 is EOL as of previous month (November 1st), one of the two patches should still stay visible.
- 🇦🇺Australia ELC
Should be able to get away with the MR patch which is identical to #3, #7 and #10.
https://git.drupalcode.org/project/commerce_stock/-/merge_requests/16.diff
Updated issue summary.
-
guy_schneerson →
committed 6fc0eaec on 8.x-1.x
Issue #3402096: Stock compatible with Core > D9.1
-
guy_schneerson →
committed 6fc0eaec on 8.x-1.x
- Status changed to Fixed
7 months ago 5:19pm 15 December 2023 - 🇬🇧United Kingdom guy_schneerson
I committed a change to the info file requiring a version greater than 9.1. Anyone using 8 should use the patch above.
Automatically closed - issue fixed for 2 weeks with no activity.