🇳🇿New Zealand @atowl

atowl → made their first commit to this issue’s fork.

Hi guys,
It's been a while, and looking back at these patches they weren't so great.
Instead, i've created a new fork with all the patches rolled in.

Changing status to reviewed and tested,
Maintainer can choose which fork they want to include.

Hi @ahsannazir,

Yes, looks like that works as well. i think using the variable(s) --input-padding-vertical is better.
So the question now is really, which is more correct? to place the padding on the class itself or on the element within the class.
Happy either way, I'll let the maintainer decide.

Updated the issue summary with reproduction steps.
Very similar to my other issue, requires the the chosen module to be installed.

Have updated the reproduction steps.

atowl → created an issue.

atowl → created an issue.

Is this still an issue? I applied your patch and didn't see any changes.
It may have already been fixed via https://git.drupalcode.org/project/gin/-/commit/e7f72df9c693dbcdbadeabdb...

atowl → created an issue.

Found an issue with this approach, the max-age should not be set to 0, then drupal never caches it.
instead, so we can use caching, set 'contexts' to 'url'.
Not sure if its the right thing to do, as i don't know enough about caching here.

Re-rolled patch for version 4.0.7

Re-rolling patch updating for version 4.x

AlMunnings → credited atowl → .

Sorry - last patch didn't include the shift of the configuration out of the if statement. This caused a get on null error.
Fixed.

We ran into some caching issues with this, where it would not get the new entity (ie page) due to being cached already.

To solve this, moved the logic for doing the preferred link into the preprocess hook, and into its own render array with `#cache => max-age = 0`
As i understand it, it will now always re-render that array into the template. And hence always get the preferred link.
I haven't done anything quite like this before so if that's the wrong approach let me know.

Thanks

Hi,
So upgraded field_group, and attempted to make a group again. Still didn't seem to work.
Exported the configuration, it looks like

uuid: e33aede0-580e-4073-9414-23b6df01a6d3
langcode: en
status: true
dependencies:
  module:
    - field_group
    - link_attributes
    - menu_link_content
    - menu_item_fields
third_party_settings:
  field_group:
    group_advanced:
      children: {  }
      parent_name: ''
      weight: 20
      format_type: tab
      region: hidden
      format_settings:
        id: ''
        classes: ''
        description: ''
        formatter: closed
        required_fields: 1
      label: Advanced
    group_feature_box:
      children: {  }
      parent_name: ''
      weight: 20
      format_type: tab
      region: hidden
      format_settings:
        show_empty_fields: 0
        id: ''
        classes: ''
        description: 'Contains all our feature box requirements'
        formatter: closed
        required_fields: 1
      label: 'Feature Box'
id: menu_link_content..default
targetEntityType: menu_link_content
bundle: ''
mode: default
content:
  langcode:
    type: language_select
    weight: 2
    region: content
    settings:
      include_locked: true
    third_party_settings: {  }
  title:
    type: string_textfield
    weight: -5
    region: content
    settings:
      size: 60
      placeholder: ''
    third_party_settings: {  }
hidden: {  }

Does this help at all?

Hi There,

So looks like we're on version 3.1.0 of drupal/field_group, i haven't tried to export the config yet, but i'll try that.

Re-rolled patch for branch 4.x

atowl → created an issue.

Hi,

Is the test a failing test or is it part of the patch that is wrong? we'd like to use this patch.
Thanks