Fix phpcs warnings in pipeline

Created on 4 June 2025, about 1 month ago

Problem/Motivation

Now that gitlab has nice runnable pipelines, we should utilize these and fix up the gitlab ci.

Fix up phpcs warnings in pipeline

📌 Task
Status

Active

Version

1.0

Component

Code

Created by

🇳🇿New Zealand atowl

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @atowl
  • First commit to issue fork.
  • Pipeline finished with Success
    about 1 month ago
    Total: 48s
    #513909
  • Pipeline finished with Success
    about 1 month ago
    Total: 79s
    #517503
  • Merge request !162chore: test pipeline for phpcs issues → (Open) created by Unnamed author
  • Pipeline finished with Failed
    about 1 month ago
    Total: 76s
    #517509
  • Pipeline finished with Failed
    about 1 month ago
    Total: 37s
    #517510
  • Pipeline finished with Failed
    about 1 month ago
    Total: 36s
    #517511
  • Pipeline finished with Failed
    about 1 month ago
    Total: 82s
    #517513
  • Pipeline finished with Failed
    about 1 month ago
    Total: 133s
    #517517
  • Pipeline finished with Failed
    about 1 month ago
    Total: 115s
    #517520
  • Added phpcs in the gitlab-cli.yml now working on fixing the issues here.

  • Pipeline finished with Failed
    about 1 month ago
    Total: 117s
    #517553
  • Pipeline finished with Failed
    about 1 month ago
    #517559
  • Pipeline finished with Failed
    about 1 month ago
    #517560
  • Pipeline finished with Failed
    about 1 month ago
    #517562
  • Pipeline finished with Failed
    about 1 month ago
    #517563
  • Pipeline finished with Failed
    about 1 month ago
    Total: 154s
    #517564
  • Pipeline finished with Failed
    about 1 month ago
    Total: 109s
    #517569
  • Pipeline finished with Failed
    about 1 month ago
    Total: 130s
    #517573
  • Pipeline finished with Failed
    about 1 month ago
    #517580
  • Pipeline finished with Failed
    about 1 month ago
    #517581
  • Hi maintainers I have added this template, please review it

  • Pipeline finished with Failed
    about 1 month ago
    Total: 1121s
    #517584
  • Pipeline finished with Failed
    about 1 month ago
    Total: 879s
    #517591
  • Pipeline finished with Failed
    about 1 month ago
    Total: 645s
    #517598
  • Pipeline finished with Failed
    about 1 month ago
    Total: 586s
    #517604
  • Pipeline finished with Failed
    about 1 month ago
    Total: 397s
    #517617
  • Pipeline finished with Failed
    about 1 month ago
    Total: 381s
    #517620
  • Pipeline finished with Failed
    about 1 month ago
    Total: 581s
    #517627
  • Pipeline finished with Failed
    about 1 month ago
    Total: 623s
    #517636
  • Pipeline finished with Failed
    about 1 month ago
    Total: 804s
    #517645
  • Pipeline finished with Failed
    about 1 month ago
    Total: 653s
    #517647
  • Pipeline finished with Failed
    about 1 month ago
    Total: 488s
    #517661
  • Pipeline finished with Failed
    about 1 month ago
    Total: 275s
    #517669
  • PHPCS is done, Php unit though is throwing an error.

  • Pipeline finished with Failed
    about 1 month ago
    Total: 3316s
    #517674
  • 🇳🇿New Zealand atowl

    Thanks @techmantejas

    i'll get onto review this shortly.

    I was thinking we could merge all these into the gitlab-resolve branch, so that #3408084 would resolve?

  • Yup, in this MR:-

    1. Updated gitlab-ci.yml to have the template for composer phpcs phpstan phpunit
    2. Fixed phpcs issues that were occuring in file

    So you can consider the phpcs issue fixes in the src files of the module, that should solve things from this child issue.

Production build 0.71.5 2024