Disabled scripts visibility logic conflict

Created on 14 December 2023, 11 months ago

Updated 26 December 2023, 11 months ago

Problem/Motivation

Adding Google Analytics to the disabled scripts caches the script into analytics: public://eu_cookie_compliance/eu_cookie_compliance.script.js
Which is loaded always if user consented to the cookies.

The issue is that Google Analytics has own visibility settings, for example excluding admin related paths. So EU Cookie Compliance sideloading scripts completely ignores it and loads GA on all pages.

Steps to reproduce

- Install Google Analytics (default settings, just add tracking code).
- Install EU Cookie Compliance (default settings).
- Add following code into Disable JavaScripts:

https://www.googletagmanager.com/gtag/js
modules/contrib/google_analytics/js/google_analytics.js

- Visit `admin/content` page.
- In the console you will see

TypeError: Cannot read properties of undefined (reading 'trackUrlFragments')

- The reason is that GA script is sideloaded by EUCC, but Google Analytics didn't provide drupalSettings, because this path is excluded.

Proposed resolution

Better sideloading logic.

🐛 Bug report

Status

Needs review

Version

1.0

Component

Code

Created by

🇰🇬Kyrgyzstan elaman

Live updates comments and jobs are added and updated live.

Merge Requests

!134Disabled scripts visibility logic conflict
Open
🇮🇳India prashant.c
updated 11 months ago

Comments & Activities

Issue created by @elaman
Comment 11 months ago →
🇰🇬Kyrgyzstan elaman
Comment 11 months ago →
🇰🇬Kyrgyzstan elaman
Temporary fix idea. Instead of hiding the banner using css, hide it properly, which will stop from sideloading scripts when the banner is hidden. This will require the visibility settings of EU an GA match.
Comment 11 months ago →
🇮🇳India prashant.c Dharamshala
Prashant.c → made their first commit to this issue’s fork.
Merge request !134Disabled scripts visibility logic conflict → (Open) created by prashant.c
Status changed to Needs review 11 months ago8:54am 26 December 2023
Comment 11 months ago →
🇮🇳India prashant.c Dharamshala
I am not able to reproduce it locally on Drupal 10 however creating MR for the submitted patch.

Thanks!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024