- Issue created by @atowl
- 🇳🇿New Zealand atowl
Uploading the patch that was supplied in the previous issue 🐛 disabled scripts not being included after consent Active from @guillaumeg. It is the same file, just renamed to suit this issue so it can be discussed here.
- 🇳🇿New Zealand atowl
For a reproduction so far i have tried
- install drupal/google_tag^1.8
- set up a new container (my_first_container), all fake-ish data and defaults.
- changed to opt-in with categories
- created 2 categories, one for my testing, and one for analytics (both unchecked by default).
- added my disabled javascriptstest_module:modules/custom/test_module/js/console_log.js|test_module analytics:https://www.googletagmanager.com/gtag.js analytics:sites/default/files/google_tag/my_first_container/google_tag.script.js
Now accepting the analytics category i don't see either of the two scripts pop up, however ever, applying @guillaumeg's patch, i see the both appear.
I think this is the reproduction that i'm looking for.
- 🇦🇺Australia GuillaumeG
Hi @atowl,
It sounds very much like the issue I had, and the patch seems to have fixed it now. :)
- 🇳🇿New Zealand atowl
Hi @guillaumeg,
I've attached a patch of the MR, if you could just confirm that works i'll look to merge it for the next release.
Thanks!