Remove custom eu_cookie_compliance_data cache entry

pianomansam → changed the visibility of the branch 3534024-remove-custom-eucookiecompliancedata to hidden.

Merge request created.

Also adding that ✨ GPC Implementation Active requires the changes in this task.

Hi @pianomansam

So i've spent some time going over this, and i think i've tested enough to make sure this works, just making sure since this will affect performance if we do get it wrong :)

In my ddev env turned on enough caching to get the X-Drupal-Cache to have a 'HIT' on a 2nd page refresh.
(For those playing along at home i had to use

$settings['cache']['bins']['render'] = 'cache.backend.database';
$settings['cache']['bins']['page'] = 'cache.backend.database';
$settings['cache']['bins']['dynamic_page_cache'] = 'cache.backend.database';

)

I then took your patch, and placed a log message after it, cleared the caches (drush cr), and refreshed the page.
First page load after cache clearing, i saw X-Drupal-Cache: MISS, and the log message.
Every then every subsequent page load was a X-Drupal-Cache: HIT, and no log message, as it's obviously coming from the cache.

Is that what you were expecting/tested?

@atowl I think your manual testing proves that my change doesn't break page caching, at least. I'd be curious to know if it affects performance or not. I doubt it does, though. It's less about performance and more about maintainability. I don't know how we could easily test performance. Unfortunately, it doesn't look like the original issue did any performance tests, either.

Hi @pianomansam,

All merged, thanks for your time on this issue!

Automatically closed - issue fixed for 2 weeks with no activity.