- Issue created by @catch
- Merge request !11901Issue #3520057: Clean up Claro tables/tablesort/tableselect CSS. → (Open) created by Unnamed author
- 🇮🇳India sandip
Please review the changes.
I removed this piece of code as i think we dont need this part and also tested in local.
.sortable-heading > a:focus, .sortable-heading > a:hover { -webkit-text-decoration: none; text-decoration: none; }
- 🇮🇳India snehal-chibde
Hello @sandip, I have reviewed these changes on Drupal 11.x-dev, I see no regression but I have a question.
Why are we placing the file tablesort.css in 'themes/claro/css/classy/components/tablesort.css' whereas we have all table related files such as table.css, tabledrag.css etc in 'themes/claro/css/components/tabledrag.css'? Ideally it should be placed in same components folder. Can you please check once.
Added screenshots of tablesort part which is working fine. - 🇮🇳India sandip
Hi @snehal-chibde, your question sounds good to me.
@catch, @nicxvan can you please guide here should i create
tablesort.css
insideclaro/css/components
folder or the above MR usingclaro/css/classy/components/tablesort.css
is good to go ? The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- First commit to issue fork.
- 🇺🇸United States smustgrave
Probably needs to be under components. I believe all the css under classy was from previous iterations where classy was a theme in Drupal.
- 🇮🇳India sandip
I have made the suggested changes please review the MR.
One thing i noticed Do we still need to attach
css/classy/components/tablesort.css
to thedrupal.tablesort
library?
I've added a tablesort.css under the components folder of the Claro theme and attached it to the samedrupal.tablesort
library. Just want to confirm whether the Classy version is still required.