Here is the change record: https://www.drupal.org/node/3517675 →
Please review the changes.
Hii @smustgrave, Thank you for the feedback.
Yes, I manually reviewed and tested all the pages where the clearfix class was being used. After thorough testing, I confirmed that the removal does not impact the layout or functionality on any of those pages. Based on this, I proceeded to remove the class from the admin theme as it was no longer needed.
Please let me know if there's any specific page or scenario you'd like me to double-check. I'm happy to revisit and make any necessary adjustments.
- 🇺🇸United States smustgrave
@utkarsh_kumar_singh I see you removed it but did you check any of the pages that it was being used? Don't see the audit part anywhere on the ticket and seems we jumped straight to removal. So moving to NW
- @utkarsh_kumar_singh opened merge request.
Sorry my bad! that thing is only works for
table.html.twignot working forview-view-table.html.twig. Sorry for the above noice i did not notice it before. I am fixing it.Hi @nod_ thanks for the review. I wanted to clarify that I can see the table.css file being added correctly. For testing purpose, I intentionally added background-color: blue to the table tag, and I verified in the Network tab also that the stylesheet is loading as expected. Can you again have a look at it please.
For reference, I’ve attached a screenshot:
Thanks again for your guidance and for providing these valuable resources. I haven’t try any recordable changes yet, but I’m going through the documentation you shared and trying to implement the same here.
- 🇫🇷France nod_ Lille
The css is not added to pages with a table, something doesn't work here. I checked
/admin/contentwith olivero as admin theme.The file needs to have the deprecation dance: see https://www.drupal.org/about/core/policies/core-change-policies/how-to-d... → for an example you can check 📌 Move resize CSS into its own library Active
Automatically closed - issue fixed for 2 weeks with no activity.