Move reset-appearance.module.css to its own library

haven't manually test but all tests appear to be failing.

Rebased again.

Following the steps in the issue summary confirmed everything is behaving as normally.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

It didn't really need a rebase. Not sure why it thought the MR didn't apply.

can't apply as a patch or rebase the MR from the UI, need some manual rebase/merge

Rebased again.

@catch Sorry I hadn't finished the rebase yet. I was busy with work.

Ahh apologies from me too, I missed that you were already doing the rebase (although I think I ended up rebasing on top of your in-progress rebase).

These are one of few MRs I don't mind rebasing because it's nearly always because the numbers are going down :)

Is this really useful anywhere else? Can we just deprecate it and add the relevant parts directly to Claro's CSS for .tabs__trigger?

@longwave we can't deprecate a files only a library, so that could happen in a follow-up, but not really here, unless we remove it without deprecation.

By moving it to its own library anyone who was using it has to make changes by attaching that library, right?

So if they have to make changes anyway maybe we just remove it instead, because this feels kinda useless on its own.

#17 that's pretty accurate. If we remove it outright, we'd need to do the following:

1. Copy the CSS to somewhere in stable9 that's always loaded. stable9 doesn't have a catch-all file, only overrides, so either need to pick an existing file that's not a perfect match or add a legacy.css or something.

2. Add the CSS to Claro's tabs CSS somewhere.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

I'm not sure why it thought the MR no longer applies. It was fine. Restoring RTBC.

It actually needed a rebase today. But now the tests are failing due to deprecations with the following warning:

Targeting system/base css/components/reset-appearance.module.css from starterkit_theme library_overrides is deprecated in 11.2.0 and will be removed in 12.0.0. Target core/drupal.reset-appearance misc/components/reset-appearance.module.css instead. See https://www.drupal.org/node/3432346 →

I restored the original changes from the MR properly. Sorry about that everyone.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

It didn't actually need a rebase, but I did one anyway just to be certain. Restoring RTBC.