- Issue created by @catch
- Merge request !11620Issue #3515093: Olivero table.css should be in its own library and #attached to tables โ (Open) created by Unnamed author
- ๐บ๐ธUnited States smustgrave
Seems pretty straight forward
@sandip poddar looking at your post history, could probably elevate past novice tagged issues. Thanks!
- ๐ฎ๐ณIndia sandip
Thanks @smustgrave! I'll definitely start looking into more advanced issues.
- ๐ซ๐ทFrance nod_ Lille
The css is not added to pages with a table, something doesn't work here. I checked
/admin/content
with olivero as admin theme.The file needs to have the deprecation dance: see https://www.drupal.org/about/core/policies/core-change-policies/how-to-d... โ for an example you can check ๐ Move resize CSS into its own library Active
- ๐ฎ๐ณIndia sandip
Hi @nod_ thanks for the review. I wanted to clarify that I can see the table.css file being added correctly. For testing purpose, I intentionally added background-color: blue to the table tag, and I verified in the Network tab also that the stylesheet is loading as expected. Can you again have a look at it please.
For reference, Iโve attached a screenshot:
Thanks again for your guidance and for providing these valuable resources. I havenโt try any recordable changes yet, but Iโm going through the documentation you shared and trying to implement the same here.
- ๐ฎ๐ณIndia sandip
Sorry my bad! that thing is only works for
table.html.twig
not working forview-view-table.html.twig
. Sorry for the above noice i did not notice it before. I am fixing it. - ๐ฎ๐ณIndia sandip
Here is the change record: https://www.drupal.org/node/3517675 โ
Please review the changes.
- ๐บ๐ธUnited States smustgrave
Cleaned up the CR a bit. Don't think we needed to include the MR as a patch, and tweaked the versions.