Change the approach for retrieving comment nodes

Created on 30 June 2024, 6 months ago

Problem/Motivation

The current approach is not the most performant (using document.querySelectorAll()). Besides this, the current approach is not covering comments for element html. Its comments are rendered before the first DOM element opening, thus causing it not to be displayed.

Proposed resolution

Change the approach to use document.createTreeWalker(), which should also be more performant.

Remaining tasks

Update the code to use document.createTreeWalker() instead of document.querySelectorAll().

✨ Feature request

Status

Fixed

Version

1.0

Component

Code

Created by

🇧🇷Brazil mabho Rio de Janeiro, RJ

Live updates comments and jobs are added and updated live.

frontend performance

front end performance

Merge Requests

!11Change the approach for retrieving comment nodes
Merged
🇧🇷Brazil mabho
updated 6 months ago

Comments & Activities

Issue created by @mabho
Merge request !11Resolve #3458164 "Improve parsing comments" → (Merged) created by mabho
Status changed to Fixed 6 months ago5:09pm 30 June 2024
Comment 6 months ago →
🇧🇷Brazil mabho Rio de Janeiro, RJ
Pipeline finished with Skipped
6 months ago
#212329
Comment 6 months ago →
System Message

mabho → committed 3a97b42a on 1.0.x
Issue #3458164: Change the approach for retrieving comment nodes
Comment 6 months ago →
🇧🇷Brazil mabho Rio de Janeiro, RJ
Status changed to Fixed 6 months ago5:10pm 30 June 2024
Comment 6 months ago →
🇧🇷Brazil mabho Rio de Janeiro, RJ

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024