The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
about 2 years ago 8:44am 19 February 2023 - 🇺🇸United States bnjmnm Ann Arbor, MI
Even though these largely appear to be safe changes, this still means that many styles that used to load on every page will now only load in specific scenarios, so regressions may occur. This should get some kind of regression testing with a tool like BackstopJS or Wraith. I used Wraith to test some of the D8-D9 changes such as removing Classy and updating Normalize.css, and it caught many regressions that manual testing didn't. I think this should get something similar.
There's another risk outside of core, and that is contrib modules expecting styles to be present that might no longer be there after these changes as they took advantage of the stylesheets happening to be there and not explicitly including them. There may be higher risk of this with some stylesheets than with others. These risks (or lack thereof) should probably be documented here so there's reasonable evidence regarding how safe it is to introduce these changes.
- 🇺🇸United States smustgrave
So question.
I agree with the concept of the ticket but is it worth the possible disruption?
- Status changed to Needs work
almost 2 years ago 8:47am 27 March 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.