- Issue created by @catch
- πΊπΈUnited States kentr Durango, CO
Possible duplicate of π Refactor system/base library Needs work , as some work for
tablesort
has already been done in that issue. - Status changed to Closed: duplicate
8 months ago 11:13pm 25 July 2024 - π¬π§United Kingdom catch
Good point - I think I opened this before I found that one. Closing.
- Status changed to Active
8 months ago 9:46pm 26 July 2024 - π¬π§United Kingdom catch
Actually no. We should split the change out to here since it's tricky.
- First commit to issue fork.
- πΉπΉTrinidad and Tobago xamount
I've adjusted the tablesort.module.css but I could not figure where is the best place to attach the new library.
Someone please review and guide me here.
- π¬π§United Kingdom catch
@xamount this is a tricky one, I ended up opening a new MR because there's been some related changes in core since your branch was open. With attachments, I wasn't sure either but added a template_preprocess implementation which works and is at least compact.
- πΊπΈUnited States smustgrave
So the way I tested this one was by just created a few nodes with A,B,C in front of the title. Then on the content view verified the table sorting worked as expected.
If different types of sorting are needed let me know, else believe this is good.
- First commit to issue fork.
- π¬π§United Kingdom catch
Updated the icon paths, good spot, not sure how I missed it in manual testing, maybe claro overrides hid the bug?
The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.