- 🇺🇸United States smustgrave
Self review
Fairly positive more nesting could be done.
Believe the goal is move away from needing [dir="rtl"]So sending back to NW
- Status changed to Needs review
over 1 year ago 1:38am 15 March 2023 - 🇮🇳India gauravvvv Delhi, India
Improved nesting in #34, attached interdiff for same. please review
- Status changed to Needs work
over 1 year ago 11:24am 15 March 2023 - Status changed to Needs review
over 1 year ago 3:23am 16 March 2023 - Status changed to Needs work
over 1 year ago 1:34pm 16 March 2023 - last update
over 1 year ago Patch Failed to Apply - Status changed to Needs review
over 1 year ago 6:32am 5 May 2023 - last update
over 1 year ago Build Successful - 🇮🇳India gauravvvv Delhi, India
I have attached a re-rolled patch and fixed nesting. please review
- last update
over 1 year ago Patch Failed to Apply - Status changed to Needs work
over 1 year ago 11:14pm 6 May 2023 - 🇺🇸United States smustgrave
#40 appeared to have issues also.
Think this is showing that backwards compatibility is not covered.
Think we need to determine how this will be done so it doesn't break existing sites.
Issue summary needs some love too as it appears to have been written for D8.
- First commit to issue fork.
- @nayana_mvr opened merge request.
- 🇮🇳India nayana_mvr
Re-rolled patch for D11 and raised MR. Keeping it in 'Needs Work' status as there are Nightwatch test failure issue in the pipeline.
Obseration:-
These changes need to be implemented in field group also right? I noticed that the same classes are used in field group also.