[Meta] Move module.theme.css files to Classy or Seven

Created on 15 May 2015, almost 10 years ago
Updated 8 May 2023, almost 2 years ago

Problem/Motivation

In πŸ“Œ [meta] Consensus Banana Phase 2, transition templates to the starterkit theme Postponed: needs info we moved a lot of templates from modules to Classy, the CSS that relies on the classes in Classy is still in the modules files

Proposed resolution

Move the CSS that relies on the HTML classes for every module. Ensure that the classes aren't being added in the module.

Remaining tasks

Test steps

Check that the CSS file was deleted from the module and added to Classy
Check that the references to that CSS file and library are removed from the module
Check that the CSS file is being loaded in the correct places in Classy
Check that there are no HTML classes in the module that relies on the theme CSS

User interface changes

None for Classy, Stark will be more Stark

API changes

None

🌱 Plan
Status

Postponed: needs info

Version

10.1 ✨

Component
CSSΒ  β†’

Last updated 3 days ago

Created by

πŸ‡¬πŸ‡§United Kingdom lewisnyman Nomadic

Live updates comments and jobs are added and updated live.
  • CSS

    It involves the content or handling of Cascading Style Sheets.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States bnjmnm Ann Arbor, MI
    • Issue summary needs updating as it is targeting themes that have been removed
    • It should be determined if this is even still desirable because:
      • There is now libraries_extends and libraries_override
      • Enough time has passed that this might not be desirable for Drupal anymore. This needs to be verified before moving further
      • Even if there are benefits to the approach, we also have to recognize that it would be disrupting something that has been in place for nearly 10 years. Are the benefits worth that disruption?
  • πŸ‡ΊπŸ‡ΈUnited States bnjmnm Ann Arbor, MI
  • πŸ‡«πŸ‡·France andypost

    There's following files in 10.1 core

    ./core/themes/stable9/css/toolbar/toolbar.icons.theme.css
    ./core/themes/stable9/css/toolbar/toolbar.theme.css
    ./core/themes/stable9/css/contextual/contextual.icons.theme.css
    ./core/themes/stable9/css/contextual/contextual.theme.css
    ./core/themes/stable9/css/taxonomy/taxonomy.theme.css
    ./core/themes/stable9/css/views_ui/views_ui.admin.theme.css
    ./core/themes/stable9/css/content_moderation/content_moderation.theme.css
    ./core/themes/stable9/css/settings_tray/settings_tray.theme.css
    ./core/themes/stable9/css/shortcut/shortcut.theme.css
    ./core/themes/stable9/css/shortcut/shortcut.icons.theme.css
    ./core/themes/stable9/css/update/update.admin.theme.css
    ./core/themes/claro/css/theme/views_ui.admin.theme.css
    ./core/themes/claro/css/theme/toolbar.icons.theme.css
    ./core/themes/claro/css/theme/filter.theme.css
    ./core/themes/claro/css/theme/tour.theme.css
    ./core/themes/claro/css/theme/toolbar.theme.css
    ./core/themes/olivero/css/theme/filter.theme.css
    ./core/modules/toolbar/css/toolbar.icons.theme.css
    ./core/modules/toolbar/css/toolbar.theme.css
    ./core/modules/system/tests/modules/css_disable_transitions_test/css/disable_transitions.theme.css
    ./core/modules/contextual/css/contextual.icons.theme.css
    ./core/modules/contextual/css/contextual.theme.css
    ./core/modules/taxonomy/css/taxonomy.theme.css
    ./core/modules/views_ui/css/views_ui.admin.theme.css
    ./core/modules/content_moderation/css/content_moderation.theme.css
    ./core/modules/settings_tray/tests/modules/settings_tray_test_css/css/css_fix.theme.css
    ./core/modules/settings_tray/css/settings_tray.theme.css
    ./core/modules/shortcut/css/shortcut.theme.css
    ./core/modules/shortcut/css/shortcut.icons.theme.css
    ./core/modules/update/css/update.admin.theme.css
    ./core/profiles/demo_umami/themes/umami/css/components/tour/tour.theme.css
    
  • πŸ‡ΊπŸ‡ΈUnited States bnjmnm Ann Arbor, MI

    I have to assume the list of files in #81 are there to provide information that moves the issue forward, but I'm unfortunately not sure what that is.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Since both themes have been removed should this be closed.

  • πŸ‡¬πŸ‡§United Kingdom catch

    🌱 [Meta] Move module.theme.css files to Classy or Seven Postponed: needs info is open from the child issues, and was rescoped to Claro.

    It's not clear to me if the child issues represent all the intended work here or not. If they do, we've got one or two left and it could be closed. If it doesn't, then the entire issue summary needs a rewrite with clear next steps.

Production build 0.71.5 2024