- Status changed to Needs review
over 1 year ago 2:29pm 2 July 2023 - last update
over 1 year ago Patch Failed to Apply - Status changed to Needs work
over 1 year ago 3:07pm 2 July 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
#22 Patch will affect the other dialog styling
Digging into this issue I found two test cases -
First Case - When placing a block on the desktop and then resizing the screen on mobile view the modal has a padding issue from the left side.
See - place-block-popup-on-desktop.mp4Second Case - When first resizing the screen on mobile view then placing the block and seeing modal works fine.
See - place-block-popup-on-mobile-screen.mp4- last update
10 months ago Patch Failed to Apply - Status changed to Needs review
10 months ago 4:36am 25 January 2024 - 🇮🇳India gauravvvv Delhi, India
Addressed feedback from #25. Not attaching interdiff as patch #22 no longer applies.
- last update
10 months ago 26,048 pass, 1,850 fail - Assigned to divya.sejekan
- last update
10 months ago 30,896 pass, 12 fail - last update
10 months ago Build Successful - Issue was unassigned.
- Status changed to Needs work
10 months ago 7:53am 25 January 2024 - 🇮🇳India divya.sejekan
Verified using patch- 3209870-26.patch in #26
After and Before patch result are both same no difference.
The MR is giving error.Testing steps :
1. Install Drupal, set the Claro theme
2. Open Block Layout
3. open place blockMoving to Need work
- 🇮🇳India ajaypratapsingh
I have gone this frontend issue on claro theme. In claro theme there is not a lot of space to adjust a table of drupal modal on mobile view. So Horizontal scroller will be shown for watch full drupal-modal. As I think if table structure will come into the drupal-modal then Horizontal Scroller will also come mobile view. It can be adjustable till if there is space for adjust on mobile view.
We can see difference between two different theme drupal-modals.
attaching ScreenShot.
1. Claro theme drupal-modal Screenshot
2. Bartik theme drupal-modal Screenshot - Status changed to Needs review
9 months ago 12:55pm 6 February 2024 - Status changed to Needs work
9 months ago 8:22pm 6 February 2024 - 🇺🇸United States smustgrave
Have not reviewed or tested
But issue summary should follow standard issue template.