- Issue created by @shweta__sharma
- Merge request !2animal_shelter-3414932: Fixed the social media icon path issue. → (Open) created by shweta__sharma
- Status changed to Needs review
11 months ago 10:58am 16 January 2024 Fixed the social media icon path issue. Kindly review it.
Thanks- Status changed to Needs work
11 months ago 12:02pm 19 January 2024 - 🇮🇳India divya.sejekan
Verified and issue is fixed
Verified on drupal 9.5x with MR! 2 #3But since twitter is changed to X , its icon also needs to change. So moving it to need Work
- Status changed to Needs review
11 months ago 10:46am 7 February 2024 Updated twitter icon with the new one. Kindly review it.
Thanks- Status changed to RTBC
10 months ago 6:18pm 14 February 2024 - 🇮🇳India divya.sejekan
Verified the updated twitter icon .. look fine
Moving to RTBC - Status changed to Needs work
about 1 month ago 10:25am 6 November 2024 Hello everyone,
Thanks for taking time out and working on the issue. I appreciate the efforts. Though the MR looks good and apparently solves the issue, but I see further scope of improvement on it.
1. The a tag is missing href, title and aria-label attribute which will cause accessibility issue.
2. Styling of cursor should be changed to a pointer on these, which generally done in case of all a tags.
3. It'll be better in terms of performance to use any icon-font library like fontawesome or icomoon icons instead of wrapping svg icons over an img tag.
4. To ease the UX, IMO it'll be better to have these configurable through a theme settings form. Its not handy to override templates to add desired social media links!I loved the way the hover effects have been incorporated with the gradients, but a bit sceptical about the X logo hover effect, tbh not looking that great to me, on bonus if anyone can come up with any alternative hover effect that'll also be appreciated!
Hence I'm moving this issue to NW again and updating the IS for better clarity :)This is what wave tools is also reporting in terms of accessibility that I've mentioned on my previous comment!
Also on using img tag alt attribute is missing. Though I'd like to get rid of img tags here :)- 🇮🇳India Tirupati_Singh
Hi @sourojeetpaul, I've added the configuration fields for social media icons. Additionally, I've added a field to Show/Hide social media title element. Please review the MR changes. Attaching the screenshots for your reference.
Thanks!