Social media icons are not visible

Fixed the social media icon path issue. Kindly review it.
Thanks

Verified and issue is fixed
Verified on drupal 9.5x with MR! 2 #3

But since twitter is changed to X , its icon also needs to change. So moving it to need Work

Updated twitter icon with the new one. Kindly review it.
Thanks

Verified the updated twitter icon .. look fine
Moving to RTBC

Hello everyone,
Thanks for taking time out and working on the issue. I appreciate the efforts. Though the MR looks good and apparently solves the issue, but I see further scope of improvement on it.
1. The a tag is missing href, title and aria-label attribute which will cause accessibility issue.
2. Styling of cursor should be changed to a pointer on these, which generally done in case of all a tags.
3. It'll be better in terms of performance to use any icon-font library like fontawesome or icomoon icons instead of wrapping svg icons over an img tag.
4. To ease the UX, IMO it'll be better to have these configurable through a theme settings form. Its not handy to override templates to add desired social media links!

I loved the way the hover effects have been incorporated with the gradients, but a bit sceptical about the X logo hover effect, tbh not looking that great to me, on bonus if anyone can come up with any alternative hover effect that'll also be appreciated!
Hence I'm moving this issue to NW again and updating the IS for better clarity :)

This is what wave tools is also reporting in terms of accessibility that I've mentioned on my previous comment!
Also on using img tag alt attribute is missing. Though I'd like to get rid of img tags here :)

Working on it.

Hi @sourojeetpaul, I've added the configuration fields for social media icons. Additionally, I've added a field to Show/Hide social media title element. Please review the MR changes. Attaching the screenshots for your reference.

Thanks!

Hi @tirupati_singh,
Thanks for taking your time out and picking up the issue. The changes look good to me. But the MR is having some errors, can you kindly resolve those, then I'd be happy to ship it in!

Hi @sourojeetpaul, I've updated the MR. Please review the changes.
Thanks!

@tirupati_singh

Reviewing the changes, thanks!

@sourojeetpaul @tirupati_singh

I thoroughly reviewed both MR and the Social Icon Configure. So it's looks good to me.

Please check uploaded screenshot.

So i am moving this to RTBC.

Thank you!!

Thanks all for your contribution on this issue. The changes look good! Hence I'm going forward with this!

Automatically closed - issue fixed for 2 weeks with no activity.