- Issue created by @alok_singh
- Merge request !10animal_shelter-3424263: Need Space between two articles. → (Open) created by alok_singh
- Status changed to Needs review
10 months ago 8:04am 28 February 2024 - Status changed to RTBC
10 months ago 8:57am 28 February 2024 Verified MR10 on 9.5.x, the space is added between articles. Added screenshots for reference, RTBC++
- Status changed to Needs work
about 2 months ago 12:46pm 6 November 2024 Hi @alok_singh,
Thanks for creating and working on the issue. I've added a small comment on the MR, so if you can kindly adjust it accordingly, apart from that the MR has some merge conflicts also now, so we need to fix that as well!
Hence moving this back to NW :(- First commit to issue fork.
- 🇮🇳India jaydeep_patel Ahmedabad
Hello,
I have added space between two articles. I have attached screenshot for reference.Thank you
Hello,
@jaydeep_patel The changes on your MR looks good to me, but I don't there was need to open any further MR when there was already an opened MR, we just had to resolve the conflicts. On the other hand @alok_singh, even though the merge conflicts have been addressed and the MR is now mergable, but I don't see the issues which I pointed out have yet been taken care of. Hence moving the issue back to NW.
Please keep any one MR and try to address all these small changes. We shouldn't be opening multiple MRs unnecessarily.- First commit to issue fork.
- 🇮🇳India akulsaxena
@sourojeetpaul
I resolved the Merge Conflict, Please give it a check. - 🇮🇳India akulsaxena
akulsaxena → changed the visibility of the branch animal_shelter-3424263 to hidden.
- 🇮🇳India akulsaxena
akulsaxena → changed the visibility of the branch animal_shelter-3424263 to active.
- 🇮🇳India akulsaxena
@sourojeetpaul
I resolved the Merge Conflict again after a new commit was added to source branch, Please give it a check. -
sourojeetpaul →
committed 6c232454 on 1.0.x authored by
jaydeep_patel →
Issue #3424263: Need Space between two articles
-
sourojeetpaul →
committed 6c232454 on 1.0.x authored by
jaydeep_patel →
Thanks @akulsaxena, for your prompt action. The changes are reflecting properly, hence I'm moving ahead with this.
Attaching quick screenshot ref for better transparency :)Automatically closed - issue fixed for 2 weeks with no activity.