strpos issue with installation

Hi, I have created the patch for the above issue. Please review.

The patch works for me and solves that problem.

Now I'm seeing this problem:

Warning: file_get_contents(themes/contrib/sailor/dist/css/main.css): Failed to open stream: No such file or directory in Drupal\Core\Asset\CssCollectionOptimizerLazy->generateHash() (line 43 of core/lib/Drupal/Core/Asset/AssetGroupSetHashTrait.php).

It seems like the subdirectory "dist" is mentioned in several places, but I don't see it.

For instance:

sailor.libraries.yml:    dist/js/main.js:
sailor.libraries.yml:      dist/css/main.css:

But here are the files in my root:

2-3412174.patch  config              images       package.json       sailor.breakpoints.yml  sailor.theme    tests
bin              docker-compose.yml  js           package-lock.json  sailor.info.yml         screenshot.png  webpack.config.js
composer.json    Dockerfile          LICENSE.txt  phpcs.xml          sailor.layouts.yml      scss
composer.lock    favicon.ico         logo.svg     README.txt         sailor.libraries.yml    templates

Hi, have you followed up with the license requirements and the npm ci command mentioned on the module page. I am not sure; maybe be this can be the reason for the issue. I hope it helps.

Gautam_105@ → made their first commit to this issue’s fork.

@samir_shukla , i have tested given patch that have fixed above issue so created MR for the same and moving RTBC++

Seems like there's a merge error, pls fix the merge conflicts :)

Hi,

I have verified the strpos issue with installation with the #3412174 merge request applied cleanly in the Drupal 10 version.

Testing Steps:
-> Install the Drupal 10 version.
-> Apply the Mr on the Theme.
-> Go to the /admin/appearance and install the theme and set as a default.
-> installed Cleanly and theme page accessible.

Testing Results:
Showing no errors and warnings On the theme page.

Attached The after screenshots. Based on these results, the issue can be moved to RTBC.

RTBC+1

Hi,
Thanks for working on this issue. But I'm not sure why @Chandansha had to create a new MR when there was already an MR, its absolutely unnecessary to create new MR to solve merge conflicts, it could have been easily done on MR!8.
The problem has already been addressed on MR!8, so pls fix the merge conflict as a part of that MR only instead of creating new MR for such small task and close the new MR

Hello @sourojeetpaul,
When i pull it from 3412174-strpos_issue and check in my local i did not find any conflict changes that's why i created new Branch and created my changes in new branch.

i followed steps to resolve conflict.
1. Take pull from 3412174-strpos_issue.
2. Paste command which available in show command button.
3. Click on overview tab.
4. And click on Resolve locally link
5. i pasted all command which provide in this link.

Thanks!!

Hi @Chandansha,
I think a rebase is required here to solve the merge conflicts!

I've resolved the merge conflicts of MR!8. Please review the changes. Getting no errors while installing the theme.

I have successfully reproduced this issue for tag 3.0.2 and applied the patch against 3.0.2, but the patch failed to apply. I also tried to reproduce this issue for the 2.x branch, but it does not exist there. I am changing the status to 'Needs Work.

Hi @atul_ghate, the issue is present on the tag 3.0.2 only as the maintainer has not published the new release for the theme. The raised issue is not present on the 2.x branch and it was fixed in the issue The website encountered an unexpected error after installation 🐛 The website encountered an unexpected error after installation. Fixed . As the code has been merged on the 2.x branch that's why the patch is not getting applied using the composer. If you'll apply the patch by cloning the project repo then it will apply with no errors. This needs maintainer review.

Thanks @tirupati_singh for the research. I'll roll out the new release after this issue is resolved Automated Drupal 11 compatibility fixes for sailor 📌 Automated Drupal 11 compatibility fixes for sailor Needs review
So that the new release will be compatible with D11 with all the remaining issues being addressed.
I'll highly appreciate if anyone can have a look at that issue and help move that forward.
Hence keeping the issue assigned to myself as of now!

Hello there,
Sorry for the delay, I got caught up on something else in the mean time. Clearing up the issue queue today.
As per the latest conversation as the stated problem is getting resolved through another issue, thus I'm labelling it as a duplicate issue.
I highly appreciate the contribution from all of you, so I'd be granting credits to all of you for putting in your efforts and valuable time!

Thanks :)