- Issue created by @ravi kant
- Status changed to Needs review
about 2 months ago 6:54am 6 November 2024 Hi @ravi kant,
First of all, I'd like to say I loved using your theme, and its good to see that you're open to have discussions regarding improvement scopes for the same. Though in this comment I'm not gonna talk about any UI changes, rather I'd like to highlight some parts regarding automation and coding standard. As of now, the theme is missing stylelint and eslint configuration, so I think it'll be a good idea to have these configurations on the theme, so as to align the Js and stylesheets with the widely used industry standard. Apart from that, we can have functions defined for these as well on the gulpfile, in order to get notified while building the assets on the go, which in turn can seem to be effective on streamlining the whole process.
So I was thinking to go about creating a couple of issues encompassing these:
1. Configure stylelint and eslint.
2. Have linting functions defined on gulp build tool.
3. Address the errors thrown while linting on the existing codebase.
4. Address Phpcs issues(if any) to have a clean and standardised codebase.Moving the issue to NR, to listen to your thoughts!
- 🇮🇳India ravi kant Jaipur
@sourojeetpaul
Nice suggestion
I will do as i am getting sufficient time for these task. Ok cool! Thanks @ravi kant for your prompt reply.
Do let me know if I could be of any help :)