- Issue created by @lostcarpark
- Merge request !19Issue #3526506: Added VerifyEmailTokensHook class. → (Merged) created by arunsahijpal
- 🇮🇳India arunsahijpal
@lostcarpark,
I've added the class, please review. - 🇮🇪Ireland lostcarpark
Than you for working on this. There is just one small change needed to remove the attribute on the class. The attribute should be on functions within the class, not on the class itself.
- 🇮🇪Ireland lostcarpark
Looks perfect now, and tests are passing (except for PHPCS warning about unused use statement, which is expected).
Moving to RTBC.
-
lostcarpark →
committed 5ba4d2fe on 1.0.x authored by
arunsahijpal →
Issue #3526506: Added VerifyEmailTokensHook class.
-
lostcarpark →
committed 5ba4d2fe on 1.0.x authored by
arunsahijpal →
-
lostcarpark →
committed b12713ad on 1.1.x
Resolve #3526506 "For 1.1.x"
-
lostcarpark →
committed b12713ad on 1.1.x
- 🇮🇳India arunsahijpal
@lostcarpark I think we should also change the state of this issue as the MR is merged.
- Merge request !21Revert "Issue #3526506: Added VerifyEmailTokensHook class." → (Merged) created by lostcarpark
-
lostcarpark →
committed 44d5e710 on 1.0.x
Revert "Issue #3526506: Added VerifyEmailTokensHook class."
-
lostcarpark →
committed 44d5e710 on 1.0.x
- 🇮🇪Ireland lostcarpark
Sorry for the shenanigans around merge requests. I accidentally merged into 1.0. I have now merged into 1.1, and reverted from 1.0.
Moving to fixed, ready for follow up issues to do the real work.
Thanks for your work on this.