- Issue created by @Greg Boggs
- 🇬🇧United Kingdom catch
I can reproduce.
From what I can tell, although the teaser for events shows media small, and media small is set to use a responsive image, for some reason it's not actually rendering the picture element on the teaser.
Also when I checked the image style for 'Uncropped | 300w | WebP' it doesn't look like it actually does the conversion to webp.
Not sure if this should go under events or media, but maybe media? So moving there.
- 🇬🇧United Kingdom catch
I think I found it - card view mode uses 'thumbnail', not a responsive image style. So two separate bugs here afaict.
- 🇺🇸United States Greg Boggs Portland Oregon
So, the events recipe uses an unexpected render method and should be updated. And some of the image styles need updating to convert to webp.
Most of the styles converts to Webp. Here are the image styles not converting to webp:
1:1 | 300x300 | Focal Point | WebP
3:4 | 225x300 | Focal Point | WebP
3:4 | 450x600 | Focal Point | WebP
4:3 | 300x225 | Focal Point | WebP
Linkit result thumbnail
Social media - Facebook
Social media - X (Twitter)
Uncropped | 300w | WebP - 🇺🇸United States phenaproxima Massachusetts
We'll want test coverage here to ensure that all the image styles we ship include a conversion to WebP.
- First commit to issue fork.
- Merge request !485Issue #3502046: Add WebP conversion to image styles → (Merged) created by annmarysruthy
- 🇺🇸United States phenaproxima Massachusetts
phenaproxima → changed the visibility of the branch 3502046-webp-conversion to hidden.
- 🇺🇸United States phenaproxima Massachusetts
phenaproxima → changed the visibility of the branch 3502046-webp-conversion to active.
- 🇺🇸United States phenaproxima Massachusetts
This is clearly a bug (AFAIK, all the image styles were meant to be converted to WebP) so backporting to 1.0.x. That means it'll need manual update steps in the release notes.
-
phenaproxima →
committed 6331e834 on 1.x authored by
annmarysruthy →
Issue #3502046 by phenaproxima, annmarysruthy, greg boggs: Update image...
-
phenaproxima →
committed 6331e834 on 1.x authored by
annmarysruthy →
- 🇺🇸United States phenaproxima Massachusetts
Merged into 1.x and cherry-picked to 1.0.x, but marking as needs work for that release note.
-
phenaproxima →
committed d1ab9ddc on 1.0.x authored by
annmarysruthy →
Issue #3502046 by phenaproxima, annmarysruthy, greg boggs: Update image...
-
phenaproxima →
committed d1ab9ddc on 1.0.x authored by
annmarysruthy →
- 🇬🇧United Kingdom tonypaulbarker Leeds
Please check the release notes added to the Issue Summary accurately describe the steps.
- 🇺🇸United States Greg Boggs Portland Oregon
I added 1 step to the release notes because there are 7 styles to update rather than 6.
- 🇬🇧United Kingdom tonypaulbarker Leeds
@greg boggs
1:1 | 300x300 | Focal Point | WebP is not updated in this MR it was already fixed in 1.0.1 https://www.drupal.org/project/cms/releases/1.0.1 →
- 🇺🇸United States Greg Boggs Portland Oregon
Oph. Thanks for catching my mistake. I have reverted it back to your original.
- 🇬🇧United Kingdom tonypaulbarker Leeds
Great. Thanks for catching my mistakes in the first place!
I think we can ship the release notes.