form_alter runs on Confirm Forms and causes AJAX errors

Attached patch

Hi @perryjanssen,
This solution is working fine for me as ConfirmFormInterface do not require entity locking since they do not modify entity data directly.
Attaching ss for reference.

But we would like to here best solution from @alexpott

Thanks

I've tried to reproduce this issue usnig given steps to reproduce but could not able to do it.
I think this issue is fixed in the latest release of trash module. So we should close this ticket.

This is still an issue - I've improved the steps to reproduce in the issue summary.

I've added a test to prove the bug and prove the MR fixes the error.

I'm still think about whether the fix is correct. I think it might be. Will discuss with other maintainers.

This will be fixed by 🐛 Remove the JS route for locking an entity Active

This is now a simpler issue - there is no error because the javascript route no longer exists. However we should stop locking trash content on the restore screen because it makes no sense. Also as edit access is barred even for user 1 on trashed entities there is no point allowing locks.

Automatically closed - issue fixed for 2 weeks with no activity.