Fix ESLint Errors following Drupal coding standards and best practices

Working on it.

Hi @trackleft2,
I've resolved many eslint error , Please have a look.

Hi @arunsahijpal, thank you for your effort in attempting to resolve this issue.

I've added some comments on the merge request and changed the status back to needs work.

@trackleft2 I've ignored the tinycon.min.js and environment_indicator.js files and made the required changes and eslint job is also passing successfully so moving it to needs review. Please have a look .

I've added additional comments on the merge request, thanks.

Also, if you could please update the gitlab-ci.yml file to enforce that merge requests pass the eslint job.

eslint:
  allow_failure: false

See https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →

Hi @trackleft2,
I've resolved all the errors only the following error is left and it is due to the missing package of tinycon. Please look at this.
1:21 error Unable to resolve path to module 'tinycon' import/no-unresolved

Needed to update the eslint config to add the Global variable "TinyCon" See https://www.drupal.org/docs/develop/standards/javascript-coding-standard... →

I've tested this locally using lando, here is my lando.yml file

name: environment_indicator
recipe: drupal10
config:
  php: '8.3'
  via: apache:2.4
  webroot: web
  database: mariadb:10.6
  xdebug: false
services:
  database:
    type: compose
    services:
      image: mariadb:10.6
      command: docker-entrypoint.sh mariadbd
      restart: always
      ports:
        - '3306'
      environment:
        MARIADB_ALLOW_EMPTY_ROOT_PASSWORD: 'true'
        MARIADB_DATABASE: drupal10
        MYSQL_DATABASE: drupal10
        MARIADB_USER: drupal10
        MARIADB_PASSWORD: drupal10
  appserver:
    overrides:
      environment:
        SIMPLETEST_DB: 'mysql://drupal10:drupal10@database/drupal10'
        SIMPLETEST_BASE_URL: 'http://appserver'
      volumes:
        # Don't share our host working directory as /app. We want /app empty for composer.
        - /app
        # Instead share our host working directory as a standalone package.
        - .:/usr/local/environment_indicator
    build:
      # Create a new Drupal project and use the module as a non-packagist repository.
      - composer create-project --dev drupal/recommended-project:10.3.x /app
      - composer config extra.enable-patching true
      - composer config extra.composer-exit-on-patch-failure true
      - composer config allow-plugins.cweagans/composer-patches true
      - composer require cweagans/composer-patches
      - composer config minimum-stability dev
      - composer config allow-plugins.phpstan/extension-installer true
      - composer require --dev drupal/core-dev:^10.3 drush/drush phpspec/prophecy-phpunit:* phpstan/extension-installer mglaman/phpstan-drupal phpstan/phpstan-deprecation-rules drupal/config_inspector
      - composer require drupal/gin
      - composer require drupal/gin_toolbar
      - composer config repositories.localdev path /usr/local/environment_indicator && composer require drupal/environment_indicator:\*@dev
  node:
    type: node:20
    build:
      - yarn install
  chromedriver:
    type: compose
    services:
      image: seleniarm/standalone-chromium:4.1.4-20220429
      command: /opt/bin/entry_point.sh
tooling:
  # Provide a command to install Drupal.
  install:
    service: appserver
    cmd:
      - /app/vendor/bin/drush --root=/app/web site:install --account-mail=noreply@example.com --account-name=admin --account-pass=admin --db-url=mysql://drupal10:drupal10@database:3306/drupal10 -y --verbose
      # Set gin as the admin theme.
      - /app/vendor/bin/drush theme:install gin
      - /app/vendor/bin/drush config:set -y system.theme admin gin
      # Enable the Environment Indicator module.
      - /app/vendor/bin/drush en -y environment_indicator config_inspector gin_toolbar
      # Set the environment indicator configuration.
      - /app/vendor/bin/drush config:set -y environment_indicator.indicator fg_color '#000000'
      - /app/vendor/bin/drush config:set -y environment_indicator.indicator bg_color '#dd3f8f'
      - /app/vendor/bin/drush config:set -y environment_indicator.indicator name 'Lando'
      #Create login link
      - /app/vendor/bin/drush uli -l https://environmentindicator.lndo.site
  # Provide Drush tooling to automatically know the Drupal root.
  drush:
    service: appserver
    cmd: /app/vendor/bin/drush --root=/app/web
  phpcs:
    service: appserver
    cmd: /app/vendor/bin/phpcs -s --colors --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/environment_indicator
  # Provide PHPCBF tooling to fix coding standards.
  phpcbf:
    service: appserver
    cmd: /app/vendor/bin/phpcbf -s --colors --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/environment_indicator
  # Provide phpstan tooling to check for code quality and deprecated code.
  phpstan:
    service: appserver
    cmd: /app/vendor/bin/phpstan analyse --configuration web/modules/contrib/environment_indicator/phpstan.neon web/modules/contrib/environment_indicator
  # Provide phpunit tooling to run unit tests.
  phpunit:
    service: appserver
    cmd: /app/vendor/bin/phpunit --configuration /app/web/core/phpunit.xml.dist --bootstrap /app/web/core/tests/bootstrap.php /app/web/modules/contrib/environment_indicator
  yarn:
    service: node
    cmd: yarn
  eslint:
    service: node
    cmd: yarn run eslint --color

trackleft2 → changed the visibility of the branch 4.x to hidden.