- Issue created by @tstoeckler
- ๐ฎ๐ณIndia arunsahijpal
Hi @tstoeckler,
I've added the missing space and has also fixed phpcs but there is one test failing pls check. - ๐ฉ๐ชGermany tstoeckler Essen, Germany
I added a review on Gitlab. I would think that the failing test is random, we'll see if it continues to fail when you update the code...
Thanks for picking this up, nice work!
- ๐ฎ๐ณIndia arunsahijpal
@tstoeckler,
I've updated the code as you have asked, plc check. - ๐ฉ๐ชGermany tstoeckler Essen, Germany
Great work @arunsahijpal! I think this is quite close.
- ๐ฎ๐ณIndia arunsahijpal
Hi @tstoeckler and @smustgrave ,
I've added the test with batch and also I've updated thecontent
key check, pls review - ๐บ๐ธUnited States smustgrave
Probably want to use the ConfifEntityUpdater. Would look into views for examples
- ๐บ๐ธUnited States smustgrave
Update hook needs test coverage. And pipeline isnโt passing
- ๐ฎ๐ณIndia arunsahijpal
@smustgrave,
It would be great help if you could suggest me some change so that the pipeline could pass as it is bit problematic for me. - ๐ฎ๐ณIndia arunsahijpal
@tstoeckler,
Could please suggest me some changes to fix the pipeline. - ๐ฉ๐ชGermany tstoeckler Essen, Germany
@arunsahijpal I took a look and the failures did look fairly strange, so I triggered a rebase which in turn triggers a new pipeline. Let's see...
- Status changed to Needs work
about 1 month ago 12:05pm 18 March 2025