Patch applied cleanly on php8.1 drupal 9.5.7. Error is gone for me too. Thank you!
- Assigned to samit.310@gmail.com
- Status changed to Needs work
almost 2 years ago 4:54am 9 May 2023 - 🇮🇳India samit.310@gmail.com
#2 🐛 Warning: Undefined array key "caption" in Drupal\tablefield\Plugin\Field\FieldFormatter\TablefieldFormatter->viewElements() (line 150 of modules/contrib/tablefield/src/Plugin/Field/FieldFormatter/TablefieldFormatter.php). Needs review patch seems good, But i guess we should use Null Coalescing Operator instead of Ternary Operator.
interdiff with #2 🐛 Warning: Undefined array key "caption" in Drupal\tablefield\Plugin\Field\FieldFormatter\TablefieldFormatter->viewElements() (line 150 of modules/contrib/tablefield/src/Plugin/Field/FieldFormatter/TablefieldFormatter.php). Needs review
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 4:58am 9 May 2023 - last update
almost 2 years ago 2 pass - last update
almost 2 years ago 2 pass - Status changed to Needs work
about 2 months ago 2:37pm 15 February 2025 - 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Please use an issue fork and merge request.
- Merge request !51Issue #3326647: Fix undefined array key "caption" in TablefieldFormatter->viewElements() → (Merged) created by arunsahijpal
- 🇮🇳India arunsahijpal
Hi @liam-morland,
I have reproduced the issue on my local and got the same warning,but after applying the patch the warning disappears.
So making a MR for it.
pls check.Thanks
Arun. - 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Thanks for the patch. This needs to be rebased onto the current 3.0.x.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Please make the merge request target 3.0.x.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
The merge request has a bunch of other commits in it. It needs to be rebased so it is only the commits for this issue.
-
liam morland →
committed 5c6832d2 on 3.0.x authored by
arunsahijpal →
Issue #3326647: Fix undefined array key "caption" in TablefieldFormatter...
-
liam morland →
committed 5c6832d2 on 3.0.x authored by
arunsahijpal →
-
liam morland →
committed 84706b54 on 8.x-2.x authored by
arunsahijpal →
Issue #3326647: Fix undefined array key "caption" in TablefieldFormatter...
-
liam morland →
committed 84706b54 on 8.x-2.x authored by
arunsahijpal →
Automatically closed - issue fixed for 2 weeks with no activity.