Fix issues reported by PHPCS

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/navigation_plus/ FILE: /var/www/web/modules/contrib/navigation_plus/modules/navigation_plus_entity_workflow/src/Routing/AfterEntityWorkflowEnhancer.php -------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 13 WARNINGS AFFECTING 14 LINES -------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\EnhancerInterface. 25 | WARNING | [ ] Code after the RETURN statement on line 24 cannot be executed 26 | WARNING | [ ] Code after the RETURN statement on line 24 cannot be executed 29 | WARNING | [ ] Code after the RETURN statement on line 24 cannot be executed 30 | WARNING | [ ] Code after the RETURN statement on line 24 cannot be executed 31 | WARNING | [ ] Code after the RETURN statement on line 24 cannot be executed 35 | WARNING | [ ] Code after the RETURN statement on line 24 cannot be executed 36 | WARNING | [ ] Code after the RETURN statement on line 24 cannot be executed 37 | ERROR | [x] Expected newline after closing brace 37 | WARNING | [ ] Code after the RETURN statement on line 24 cannot be executed 38 | WARNING | [ ] Code after the RETURN statement on line 24 cannot be executed 39 | WARNING | [ ] Code after the RETURN statement on line 24 cannot be executed 40 | WARNING | [ ] Code after the RETURN statement on line 24 cannot be executed 41 | WARNING | [ ] Code after the RETURN statement on line 24 cannot be executed 48 | WARNING | [ ] Code after the RETURN statement on line 24 cannot be executed -------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/navigation_plus/modules/navigation_plus_entity_workflow/src/Routing/BeforeEntityWorkflowEnhancer.php --------------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AND 18 WARNINGS AFFECTING 17 LINES --------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\EnhancerInterface. 24 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 24 | ERROR | [x] Trailing punctuation for @see references is not allowed. 28 | WARNING | [ ] Code after the RETURN statement on line 27 cannot be executed 28 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 29 | WARNING | [ ] Code after the RETURN statement on line 27 cannot be executed 31 | WARNING | [ ] Code after the RETURN statement on line 27 cannot be executed 32 | WARNING | [ ] Code after the RETURN statement on line 27 cannot be executed 36 | WARNING | [ ] Code after the RETURN statement on line 27 cannot be executed 38 | WARNING | [ ] Code after the RETURN statement on line 27 cannot be executed 39 | WARNING | [ ] Code after the RETURN statement on line 27 cannot be executed 40 | WARNING | [ ] Code after the RETURN statement on line 27 cannot be executed 41 | WARNING | [ ] Code after the RETURN statement on line 27 cannot be executed 45 | WARNING | [ ] Code after the RETURN statement on line 27 cannot be executed 45 | ERROR | [x] There should be no white space before a closing ")" 46 | WARNING | [ ] Code after the RETURN statement on line 27 cannot be executed 47 | WARNING | [ ] Code after the RETURN statement on line 27 cannot be executed 47 | WARNING | [ ] Unused variable $_. 47 | WARNING | [ ] Unused variable $_. 48 | WARNING | [ ] Code after the RETURN statement on line 27 cannot be executed 49 | WARNING | [ ] Code after the RETURN statement on line 27 cannot be executed 52 | WARNING | [ ] Code after the RETURN statement on line 27 cannot be executed --------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/navigation_plus/modules/navigation_plus_entity_workflow/src/Controller/WorkspaceSwitcher.php ------------------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AND 3 WARNINGS AFFECTING 8 LINES ------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line 5 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface. 16 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters 31 | ERROR | [x] Missing function doc comment 44 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters 47 | ERROR | [x] Parameter $entity has null default value, but is not marked as nullable. 47 | ERROR | [x] Parameter $view_mode has null default value, but is not marked as nullable. 56 | ERROR | [x] Expected newline after closing brace 70 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters ------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/navigation_plus/modules/navigation_plus_entity_workflow/navigation_plus_entity_workflow.module --------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES --------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment 8 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 12 | ERROR | [x] Expected 1 blank line after function; 0 found --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/navigation_plus/README.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 3 | WARNING | Line exceeds 80 characters; contains 109 characters ---------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/navigation_plus/src/Plugin/Tool/Pointer.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------ 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\TranslatableMarkup. ------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/web/modules/contrib/navigation_plus/src/Plugin/Mode/Edit.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 10 ERRORS AND 4 WARNINGS AFFECTING 12 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\navigation_plus\Attribute\Mode. 34 | ERROR | [ ] Missing member variable doc comment 36 | ERROR | [x] Missing function doc comment 37 | ERROR | [x] Space before opening parenthesis of function call prohibited 52 | ERROR | [x] Multi-line function declarations must define one parameter per line 52 | ERROR | [x] Multi-line function declarations must define one parameter per line 52 | ERROR | [x] Multi-line function declarations must define one parameter per line 119 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters 151 | ERROR | [ ] Description for the @return value is missing 187 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 203 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 219 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 259 | ERROR | [ ] Description for the @return value is missing 325 | ERROR | [x] Expected 1 blank line after function; 2 found ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/navigation_plus/src/ModePluginManager.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 4 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheBackendInterface. 17 | ERROR | [ ] Missing short description in doc comment 35 | ERROR | [x] Expected "\Drupal\Core\Entity\EntityInterface|null" but found "\Drupal\Core\Entity\EntityInterface|NULL" for parameter type 35 | ERROR | [ ] Doc comment for parameter $entity does not match actual variable name <undefined> 65 | ERROR | [ ] Description for the @return value is missing ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/navigation_plus/src/ModePluginBase.php ------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------- 17 | ERROR | [x] Missing function doc comment 18 | ERROR | [x] Space before opening parenthesis of function call prohibited ------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/navigation_plus/src/LoadEditablePageResponseTrait.php --------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES --------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Missing trait doc comment 40 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters 55 | ERROR | [ ] Doc comment for parameter $view_mode does not match actual variable name <undefined> --------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/navigation_plus/src/ToolPluginManager.php ---------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ---------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheBackendInterface. 26 | ERROR | [x] Missing function doc comment 28 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found ---------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/navigation_plus/src/Form/NodeTypeEditFormAlter.php ------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AND 3 WARNINGS AFFECTING 8 LINES ------------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. 10 | ERROR | [x] Doc comment short description must end with a full stop 25 | ERROR | [ ] Missing parameter type 28 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces 40 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 42 | ERROR | [x] Expected newline after closing brace 59 | WARNING | [ ] Avoid backslash escaping in translatable strings when possible, use "" quotes instead 66 | WARNING | [ ] Avoid backslash escaping in translatable strings when possible, use "" quotes instead ------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/navigation_plus/src/ToolPluginBase.php ------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------- 18 | ERROR | [x] Missing function doc comment 19 | ERROR | [x] Space before opening parenthesis of function call prohibited ------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/navigation_plus/src/ModeInterface.php --------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES --------------------------------------------------------------------------------- 23 | ERROR | [ ] Description for the @return value is missing 28 | ERROR | [x] Doc comment short description must end with a full stop 53 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 4 spaces 70 | ERROR | [ ] Description for the @return value is missing --------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/navigation_plus/src/Event/ShouldNotEditModeEvent.php --------------------------------------------------------------------------------------- FOUND 6 ERRORS AFFECTING 6 LINES --------------------------------------------------------------------------------------- 8 | ERROR | [x] Missing class doc comment 12 | ERROR | [ ] Missing member variable doc comment 14 | ERROR | [x] Missing function doc comment 18 | ERROR | [x] Missing function doc comment 22 | ERROR | [ ] Missing short description in doc comment 23 | ERROR | [ ] Description for the @return value is missing --------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/navigation_plus/src/Controller/LoadEditablePage.php ---------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 5 LINES ---------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Controller\ControllerBase. 28 | ERROR | [x] Missing function doc comment 59 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 61 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 75 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead ---------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/navigation_plus/src/EventSubscriber/EntityUiWrapper.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 8 ERRORS AND 1 WARNING AFFECTING 7 LINES ------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line 1 | ERROR | [x] Expected 1 line before declare statement, found 0. 1 | ERROR | [x] Expected strict_types=1, found strict_types = 1. 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\navigation_plus\ModePluginManager. 12 | ERROR | [x] Missing class doc comment 20 | ERROR | [x] Missing function doc comment 40 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters 68 | ERROR | [x] Missing function doc comment 72 | ERROR | [x] Expected newline after closing brace ------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/navigation_plus/src/EventSubscriber/ShouldNotEditMode.php -------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Path\PathMatcherInterface. 19 | ERROR | [ ] Missing member variable doc comment -------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/navigation_plus/src/ToolInterface.php ----------------------------------------------------------------------------------- FOUND 5 ERRORS AND 3 WARNINGS AFFECTING 8 LINES ----------------------------------------------------------------------------------- 24 | ERROR | [ ] Description for the @return value is missing 32 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 40 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 48 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 53 | ERROR | [ ] Doc comment short description must start with a capital letter 57 | ERROR | [ ] Description for the @return value is missing 67 | ERROR | [ ] Description for the @return value is missing 72 | ERROR | [x] Doc comment short description must end with a full stop ----------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/navigation_plus/src/NavigationPlusUi.php ------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 10 ERRORS AND 5 WARNINGS AFFECTING 14 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------ 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface. 26 | ERROR | [ ] Missing short description in doc comment 27 | ERROR | [x] Expected "\Drupal\Core\Entity\EntityInterface|null" but found "\Drupal\Core\Entity\EntityInterface|NULL" for @var tag in member | | variable comment 39 | ERROR | [x] Expected 1 space between type hint and argument "$eventDispatcher"; 2 found 78 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 103 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 129 | ERROR | [ ] Description for the @return value is missing 134 | WARNING | [ ] Unused variable $mode_id. 148 | ERROR | [x] Expected 1 blank line after function; 2 found 156 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 167 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 169 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters 169 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 207 | ERROR | [x] Expected newline after closing brace 220 | ERROR | [x] Missing function doc comment ------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/web/modules/contrib/navigation_plus/src/FlagNewPage.php --------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES --------------------------------------------------------------------------------- 10 | ERROR | [ ] Missing short description in doc comment 27 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces 29 | ERROR | [ ] Description for the @return value is missing 36 | ERROR | [x] Expected 1 blank line after function; 2 found 45 | ERROR | [ ] Description for the @return value is missing --------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/navigation_plus/navigation_plus.module -------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AND 1 WARNING AFFECTING 6 LINES -------------------------------------------------------------------------------------------------------------------------------- 3 | ERROR | [x] You must use "/**" style comments for a file comment 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface. 57 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters 107 | ERROR | [x] Missing function doc comment 127 | ERROR | [x] Expected "string|null" but found "string|NULL" for parameter type 136 | ERROR | [x] Parameter $view_mode has null default value, but is not marked as nullable. -------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/navigation_plus/css/sidebar.css ---------------------------------------------------------------------- FOUND 11 ERRORS AFFECTING 10 LINES ---------------------------------------------------------------------- 6 | ERROR | [x] Selectors must be on a single line 7 | ERROR | [x] Selectors must be on a single line 8 | ERROR | [x] Selectors must be on a single line 9 | ERROR | [x] Selectors must be on a single line 10 | ERROR | [x] Selectors must be on a single line 11 | ERROR | [x] Selectors must be on a single line 12 | ERROR | [x] Multiple selectors should each be on a single line 12 | ERROR | [x] Selectors must be on a single line 13 | ERROR | [x] Selectors must be on a single line 14 | ERROR | [x] Selectors must be on a single line 15 | ERROR | [ ] Style definitions must end with a semicolon ---------------------------------------------------------------------- PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/navigation_plus/css/navigation.css ---------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ---------------------------------------------------------------------- 14 | ERROR | [x] Selectors must be on a single line 15 | ERROR | [x] Selectors must be on a single line 16 | ERROR | [ ] Style definitions must end with a semicolon ---------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: /var/www/web/modules/contrib/navigation_plus/css/top-bar.css ---------------------------------------------------------------------- FOUND 6 ERRORS AFFECTING 6 LINES ---------------------------------------------------------------------- 4 | ERROR | [ ] Style definitions must end with a semicolon 5 | ERROR | [x] Selectors must be on a single line 6 | ERROR | [x] Selectors must be on a single line 7 | ERROR | [ ] Style definitions must end with a semicolon 28 | ERROR | [x] Expected 1 newline at end of file; 2 found 29 | ERROR | [x] Additional whitespace found at end of file ---------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- Time: 687ms; Memory: 12MB

Comments & Activities

Issue created by @abhiyanshu
First commit to issue fork.
Merge request !3Issue #3511569: Fix issues reported by PHPCS → (Open) created by Unnamed author
Comment about 2 months ago →
🇮🇳India GGH
MR Raised
Pipeline finished with Success
about 2 months ago
Total: 293s
#443293

Comment about 1 month ago →

🇵🇭Philippines paraderojether

I reviewed MR!3 and it passed phpcs using Gitlab CI, MR!3 is applied successfully against Navigation + 1.0.5 however, there are remaining issues reported by PHP_CodeSniffer:

➜  navigation_plus git:(main) ✗ curl https://git.drupalcode.org/project/navigation_plus/-/merge_requests/3.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 47768    0 47768    0     0   110k      0 --:--:-- --:--:-- --:--:--  112k
patching file README.md
patching file 'css/top-bar.css'
patching file 'modules/navigation_plus_entity_workflow/navigation_plus_entity_workflow.module'
patching file 'modules/navigation_plus_entity_workflow/src/Controller/WorkspaceSwitcher.php'
patching file 'modules/navigation_plus_entity_workflow/src/Routing/AfterEntityWorkflowEnhancer.php'
patching file 'modules/navigation_plus_entity_workflow/src/Routing/BeforeEntityWorkflowEnhancer.php'
patching file navigation_plus.module
patching file 'src/Controller/LoadEditablePage.php'
patching file 'src/Event/ShouldNotEditModeEvent.php'
patching file 'src/EventSubscriber/EntityUiWrapper.php'
patching file 'src/EventSubscriber/ShouldNotEditMode.php'
patching file 'src/FlagNewPage.php'
patching file 'src/Form/NodeTypeEditFormAlter.php'
patching file 'src/LoadEditablePageResponseTrait.php'
patching file 'src/ModeInterface.php'
patching file 'src/ModePluginBase.php'
patching file 'src/ModePluginManager.php'
patching file 'src/NavigationPlusUi.php'
patching file 'src/Plugin/Mode/Edit.php'
patching file 'src/ToolInterface.php'
patching file 'src/ToolPluginBase.php'
patching file 'src/ToolPluginManager.php'
➜  navigation_plus git:(main) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig navigation_plus

FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/navigation_plus.module
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface.
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/navigation_plus.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/css/sidebar.css
-------------------------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 10 LINES
-------------------------------------------------------------------------------------------
 13 | ERROR | [x] Selectors must be on a single line
 14 | ERROR | [x] Selectors must be on a single line
 15 | ERROR | [x] Selectors must be on a single line
 16 | ERROR | [x] Selectors must be on a single line
 17 | ERROR | [x] Selectors must be on a single line
 18 | ERROR | [x] Selectors must be on a single line
 19 | ERROR | [x] Multiple selectors should each be on a single line
 19 | ERROR | [x] Selectors must be on a single line
 20 | ERROR | [x] Selectors must be on a single line
 21 | ERROR | [x] Selectors must be on a single line
 22 | ERROR | [ ] Style definitions must end with a semicolon
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/css/top-bar.css
-------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------
 4 | ERROR | [ ] Style definitions must end with a semicolon
 5 | ERROR | [x] Selectors must be on a single line
 6 | ERROR | [x] Selectors must be on a single line
 7 | ERROR | [ ] Style definitions must end with a semicolon
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/css/navigation.css
----------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------
 14 | ERROR | [x] Selectors must be on a single line
 15 | ERROR | [x] Selectors must be on a single line
 16 | ERROR | [ ] Style definitions must end with a semicolon
----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/modules/navigation_plus_entity_workflow/navigation_plus_entity_workflow.info.yml
------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/modules/navigation_plus_entity_workflow/src/Controller/WorkspaceSwitcher.php
--------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface.
--------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/modules/navigation_plus_entity_workflow/src/Routing/AfterEntityWorkflowEnhancer.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\EnhancerInterface.
---------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/modules/navigation_plus_entity_workflow/src/Routing/BeforeEntityWorkflowEnhancer.php
----------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\EnhancerInterface.
----------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/ModePluginManager.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheBackendInterface.
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/Form/NodeTypeEditFormAlter.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait.
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/Plugin/Mode/Edit.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\navigation_plus\Attribute\Mode.
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/Plugin/Tool/Pointer.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\TranslatableMarkup.
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/ToolPluginManager.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheBackendInterface.
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/Controller/LoadEditablePage.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface.
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/NavigationPlusUi.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------------------
   9 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface.
  75 | WARNING | [ ] Unused variable $last_key.
 142 | WARNING | [ ] Unused variable $mode_id.
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/EventSubscriber/ShouldNotEditMode.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Path\PathMatcherInterface.
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/EventSubscriber/EntityUiWrapper.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\navigation_plus\ModePluginManager.
----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------

Time: 478ms; Memory: 12MB

Kindly check and advise, please.
Thank you.

Comment 22 days ago →
🇺🇸United States tim bozeman

Fix issues reported by PHPCS

Problem/Motivation

Steps to reproduce

Proposed resolution

Merge Requests

!3Fix issues reported by PHPCS
Open

Comments & Activities

Fix issues reported by PHPCS

Problem/Motivation

Steps to reproduce

Proposed resolution

Merge Requests

!3Fix issues reported by PHPCSOpen

Comments & Activities

!3Fix issues reported by PHPCS
Open