- Issue created by @abhiyanshu
- First commit to issue fork.
- šµšPhilippines paraderojether
Hi
I reviewed MR!3 and it passed phpcs using Gitlab CI, MR!3 is applied successfully against Navigation + 1.0.5 however, there are remaining issues reported by PHP_CodeSniffer:
ā navigation_plus git:(main) ā curl https://git.drupalcode.org/project/navigation_plus/-/merge_requests/3.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 47768 0 47768 0 0 110k 0 --:--:-- --:--:-- --:--:-- 112k patching file README.md patching file 'css/top-bar.css' patching file 'modules/navigation_plus_entity_workflow/navigation_plus_entity_workflow.module' patching file 'modules/navigation_plus_entity_workflow/src/Controller/WorkspaceSwitcher.php' patching file 'modules/navigation_plus_entity_workflow/src/Routing/AfterEntityWorkflowEnhancer.php' patching file 'modules/navigation_plus_entity_workflow/src/Routing/BeforeEntityWorkflowEnhancer.php' patching file navigation_plus.module patching file 'src/Controller/LoadEditablePage.php' patching file 'src/Event/ShouldNotEditModeEvent.php' patching file 'src/EventSubscriber/EntityUiWrapper.php' patching file 'src/EventSubscriber/ShouldNotEditMode.php' patching file 'src/FlagNewPage.php' patching file 'src/Form/NodeTypeEditFormAlter.php' patching file 'src/LoadEditablePageResponseTrait.php' patching file 'src/ModeInterface.php' patching file 'src/ModePluginBase.php' patching file 'src/ModePluginManager.php' patching file 'src/NavigationPlusUi.php' patching file 'src/Plugin/Mode/Edit.php' patching file 'src/ToolInterface.php' patching file 'src/ToolPluginBase.php' patching file 'src/ToolPluginManager.php' ā navigation_plus git:(main) ā cd .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig navigation_plus FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/navigation_plus.module ---------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface. ---------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/navigation_plus.info.yml ------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/css/sidebar.css ------------------------------------------------------------------------------------------- FOUND 11 ERRORS AFFECTING 10 LINES ------------------------------------------------------------------------------------------- 13 | ERROR | [x] Selectors must be on a single line 14 | ERROR | [x] Selectors must be on a single line 15 | ERROR | [x] Selectors must be on a single line 16 | ERROR | [x] Selectors must be on a single line 17 | ERROR | [x] Selectors must be on a single line 18 | ERROR | [x] Selectors must be on a single line 19 | ERROR | [x] Multiple selectors should each be on a single line 19 | ERROR | [x] Selectors must be on a single line 20 | ERROR | [x] Selectors must be on a single line 21 | ERROR | [x] Selectors must be on a single line 22 | ERROR | [ ] Style definitions must end with a semicolon ------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/css/top-bar.css ------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES ------------------------------------------------------------------------------------------- 4 | ERROR | [ ] Style definitions must end with a semicolon 5 | ERROR | [x] Selectors must be on a single line 6 | ERROR | [x] Selectors must be on a single line 7 | ERROR | [ ] Style definitions must end with a semicolon ------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/css/navigation.css ---------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ---------------------------------------------------------------------------------------------- 14 | ERROR | [x] Selectors must be on a single line 15 | ERROR | [x] Selectors must be on a single line 16 | ERROR | [ ] Style definitions must end with a semicolon ---------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/modules/navigation_plus_entity_workflow/navigation_plus_entity_workflow.info.yml ------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------------ 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ------------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/modules/navigation_plus_entity_workflow/src/Controller/WorkspaceSwitcher.php -------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface. -------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/modules/navigation_plus_entity_workflow/src/Routing/AfterEntityWorkflowEnhancer.php --------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\EnhancerInterface. --------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/modules/navigation_plus_entity_workflow/src/Routing/BeforeEntityWorkflowEnhancer.php ---------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\EnhancerInterface. ---------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/ModePluginManager.php --------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheBackendInterface. --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/Form/NodeTypeEditFormAlter.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/Plugin/Mode/Edit.php -------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\navigation_plus\Attribute\Mode. -------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/Plugin/Tool/Pointer.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------ 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\TranslatableMarkup. ------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/ToolPluginManager.php --------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheBackendInterface. --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/Controller/LoadEditablePage.php ---------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface. ---------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/NavigationPlusUi.php -------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES -------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface. 75 | WARNING | [ ] Unused variable $last_key. 142 | WARNING | [ ] Unused variable $mode_id. -------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/EventSubscriber/ShouldNotEditMode.php ------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Path\PathMatcherInterface. ------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/EventSubscriber/EntityUiWrapper.php ---------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\navigation_plus\ModePluginManager. ---------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------- Time: 478ms; Memory: 12MB
Kindly check and advise, please.
Thank you.