- Issue created by @dewalt
- π§πΎBelarus dewalt
The patch, don't contain API changes, and contain duplicate results fix too inside.
- Status changed to RTBC
over 1 year ago 5:27pm 17 August 2023 - π·πΈSerbia SAVEL
The patch applies and solves the problem. Moving to RTBC
- πͺπΈSpain bmunslow
Patch works for me too, looking forward to seeing this included in the next release!
- First commit to issue fork.
- πΊπΈUnited States trackleft2 Tucson, AZ πΊπΈ
Check the PHPCS test https://git.drupalcode.org/issue/draggableviews-3336466/-/jobs/3595980
Looks like you need to make some changesFILE: ...b/modules/custom/draggableviews-3336466/src/Plugin/views/join/WithArgs.php -------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------- 27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 5 | | (Drupal.WhiteSpace.ScopeIndent.IncorrectExact) 27 | ERROR | [x] Closing brace indented incorrectly; expected 4 spaces, found | | 5 (Drupal.WhiteSpace.ScopeClosingBrace.Indent) 37 | ERROR | [x] Whitespace found at end of line | | (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- Time: 213ms; Memory: 6MB PHP CODE SNIFFER REPORT SUMMARY -------------------------------------------------------------------------------- FILE ERRORS WARNINGS -------------------------------------------------------------------------------- ...m/draggableviews-3336466/src/Plugin/views/join/WithArgs.php 3 0 -------------------------------------------------------------------------------- A TOTAL OF 3 ERRORS AND 0 WARNINGS WERE FOUND IN 9 FILES -------------------------------------------------------------------------------- PHPCBF CAN FIX 3 OF THESE SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- PHP CODE SNIFFER VIOLATION SOURCE SUMMARY ---------------------------------------------------------------------- SOURCE COUNT ---------------------------------------------------------------------- [x] Drupal.WhiteSpace.ScopeClosingBrace.Indent 1 [x] Drupal.WhiteSpace.ScopeIndent.IncorrectExact 1 [x] Squiz.WhiteSpace.SuperfluousWhitespace.EndLine 1 ---------------------------------------------------------------------- A TOTAL OF 3 SNIFF VIOLATIONS WERE FOUND IN 3 SOURCES ---------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SOURCES AUTOMATICALLY (3 VIOLATIONS IN TOTAL) ----------------------------------------------------------------------
- πΊπΈUnited States trackleft2 Tucson, AZ πΊπΈ
Updated the merge request to address PHPCS errors.