I think it will be reasonable to have an option to disable the welcome emails.
It's possible to customize them, but not to disable them!
There are 6 email settings configurable from user settings:
Welcome (new user created by administrator)
--> When admin crates the new user, there is a checkbox "Notify user", so it's not needed in this page)
Welcome (awaiting approval)
--> (Missing!)
Welcome (no approval required)
--> (Missing!)
Account activation
--> (There is a checkbox for disabling)
Account blocked
--> (There is a checkbox for disabling)
Account cancellation confirmation
--> (Missing! But maybe shouldn't be in the admin hands if a user wants to cancel its account)
Account canceled
--> (There is a checkbox for disabling)
Password recovery.
--> (Missing!)
Maybe it's obvious that should be always on these welcome emails. But what about a web site who register their users via SMS for example, and not email? Or probably there is more use cases.
It's attached a starting patch that only adds notification checkboxes to the form, for two of the welcome messages.
With only this minimal patch will work, because the way is implemented the notification code in the _submit.
It will need more work, and possibility to modify also the message in the screen. (It's silly that email is not sent, but user sees the message "A welcome message with further instructions has been sent to your e-mail address."
I wanted to hear first more opinions or if there is some duplicated issues.
Thanks.