Can't save image widget crop settings in Drupal 11

I've created a MR that fixes the problem. Please review, thanks!

omarlopesino → changed the visibility of the branch 8.x-2.x to hidden.

Hit by the same problem, can confirm that the contributed patch fixes the problem, thanks!

Works well with D11.1.1 + IWC dev-2.x 2f10025 , thanks.

Closed 🐛 ImmutableConfigException Active as a duplicate of this issue. Ideally this should be fixed in 3.0.x-dev first but also backported to 8.x-2.x. @sweetchuck contributed to the closed issue and should also be credited here.

Hello,
the 3.0.x-dev version also produces:

Drupal\Core\Config\ImmutableConfigException: Can not set values on immutable configuration image_widget_crop.settings:settings.library_url. Use \Drupal\Core\Config\ConfigFactoryInterface::getEditable() to retrieve a mutable configuration object in Drupal\Core\Config\ImmutableConfig->set() (line 27 of core/lib/Drupal/Core/Config/ImmutableConfig.php).

I'm using the 11.1.2 Drupal version

Increasing priority to major since it is impossible to save module config currently.

Fix it by getting settings editable

Path issue with previous patch that caused patching to fail. I've fixed the paths. This one should work. I can now save settings after applying this patch.

anup.singh → made their first commit to this issue’s fork.

Latest patch are working and it seems to be correct approach, So update the MR with same.

Just ran into this, thanks for putting this together, hopefully this can be merged soon.

+1 please merge.

The MR works for me. I hope this gets merged soon -- this module is unusable without it.

I'm going to merge this to get people unblocked, even though the bug itself is due to preexisting incorrect pattern -- you are never supposed to inject a config object into a form (or any class) as a dependency.

The correct pattern would be for the form to override the getEditableConfigNames() method, and use $this->config() internally to load config. Core will guarantee that it gets editable versions of anything listed in getEditableConfigNames().

Merging this on the good-faith assumption that some kindly person will open a follow-up issue in which to do that cleanup.

The merge train has now left the station! Should be committed shortly when all tests pass.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Thanks a bunch @phenaproxima created that follow-up 📌 Refactor form to use getEditableConfigNames() and $this->config() instead of injecting config Active