Automated Drupal 11 compatibility fixes for image_widget_crop

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.1
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.1

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.2
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.2

First let's merge 📌 Fix coding standard issues + add GitLab CI to the project Needs review which brings the project's test suite back to life, then we can continue focusing on D11 compatibility.

Rajeshreeputra → changed the visibility of the branch project-update-bot-only to hidden.

@Balu-Ertl,
I wanted to address the issues you mentioned and provide my perspective on their relevance to D11 compatibility:

📌 Fix coding standard issues + add GitLab CI to the project Needs review - This is not required for D11 compatibility.
🐛 PHP 8.2 Deprecated function: Creation of dynamic property (Image Widget Crop) Needs review - This issue is not being reported anymore in CI. Please see here.
📌 When Drop Drupal 8.8 Support: Remove call to deprecated Libraries function libraries_detect() Needs work - This has been deprecated since 8.8 and is still functional in Drupal 9, 10, and 11. Therefore, it can be tackled separately and should not be included in the D11 blocker list.
✨ Create composer.libraries.json Active - This is indeed a good feature to add to the library in the require section of composer.json, but it doesn't pose a blocker for D11.
Thank you for considering this feedback.

Hence requesting review.

Rajeshreeputra → changed the visibility of the branch 3451140-automated-drupal-11-testing to hidden.

Rajeshreeputra - We should have a commit where all CI is green, then you can revert that commit by adding its CI link, so that we know everything is working with added dependencies. May be you can pull using vcs which are not compatible for next major and run the CI

Rajeshreeputra → closed merge request !25

Rajeshreeputra → reopened merge request !25

Rajeshreeputra → changed the visibility of the branch 3451140-automated-drupal-11-testing to hidden.

Rajeshreeputra → closed merge request !25

Please review.

This needs to be fixed: https://git.drupalcode.org/issue/image_widget_crop-3451140/-/jobs/236909...
Please check Phpstan next major pipeline, there are few issues which needs to be handle here
Also Drop D8 and support minimum D9.5

Update MR to fix phpstan warning with next major, hence moving in needs review.
For dropping support of Drupal core below 9.5 version, created separate issue 💬 Request to Drop Support for Drupal Core Versions Below 9.5. Active .

As configFormBase is extended and you have new argument i.e typedConfigManager in the constructor I'm not sure whether it would below D10.2

Also libraries_detect not found is this one can be resolved?

Any reasons why we aren't dropping D8 here only? Not in a favour of logging separate issue to provide support of minimum D9.5

As I mentioned earlier dropping support of Drupal core below 9.5 version is not related to adding support of Drupal core 11. Hence created separate issue.

Reviewed changes and looks good to me. As I can separate tickets have been created to fix PHPCS and PHPStan issues, hence marking RTBC.

RTBC from here too. Tested on core 10.3 and 11. +1 for all the work in here.

If anyone needs to add this module to a D11 project, here are instructions if you have not done it before.

Add the patch in your composer.json patches section.

            "drupal/image_widget_crop": {
                "#3451140": "https://git.drupalcode.org/project/image_widget_crop/-/merge_requests/24.diff"
            }

If you don't have composer-drupal-lenient yet, add it to your project first:
composer require mglaman/composer-drupal-lenient

If your minimum stability is not set to dev yet, you need to do that first:
composer config minimum-stability dev

Add this module to the lenient allowed list:
composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/image_widget_crop"]'

Now you can add this module to your D11 project:
composer require 'drupal/image_widget_crop:2.x-dev@dev'

And of course you can enable it
drush en image_widget_crop

Yes, we can do as @flyke proposed at #27.
+1 for an official release.
Thanks for working on this!

As indicated on the module page, the project seems to be looking for new co-maintainers.

If some of you are willing to apply, it might accelerate things a bit. Who knows.

I've send the maintainers a message in Slack. Would be nice if this issue lands soon.

I just wanted to prevetn too much noise here, that's why I haven't reported yet in here that I have contacted @woprrr already some days ago inviting to add me as co-maintainer to help out for a final Drupal 11 release and beyond So let us be patient and wait a little bit. A I know very well maintainers have a lot to manage. We will move on here as soon as possible.

Decrease issue prio. Descriptions of the Priority → and Status → values can be found in the Drupal project issues → documentation.

Good news: I am added. So things will move on now! :+1: I will make you patiently waiting users happy soon ;-)

Thanks for all the hard work in here and the patience for the final commit to latest dev. And to the Drupal 11 compatible upcoming release soon. Any thing you wish to have in the next release, please try to bring according issues to RTBC as soon as possible to be ready to get in.

You all rock! +1

Thanks for the merge @dqd!

Has also been merged into the new 3.0.x semantic versioning dev branch based on 8.x-2.x for the upcoming semantic versioning release with long holding RTBCs committed to both branches.

Can we assume new 2.x and 3.x release will be forthcoming in the next couple weeks?