Traversial Links Page Title Has Unexpectedly Changed

Think the update hooks were wrong can you try https://www.drupal.org/project/book/issues/3531800 🐛 'show_top_item' is not a supported key. Active

Thanks for the reply! Though I'm not sure what you'd like me to try, exactly? I took a look at that other issue and am not sure what my next steps would be...

There's an MR open on that issue.

Got it, thanks. I will need to learn how to do a merge request, actually, but will look into it and get back to you!

I haven't figured out how to do a MR yet (would be nice if there was some actual good documentation on this process somewhere), but in the meantime I see there is a fix now for https://www.drupal.org/project/book/issues/3531800 🐛 'show_top_item' is not a supported key. Active

And so I have updated to 2.0.2, which includes that fix and which should presumably also apply that MR as part of the update (?) ...

However, I see that the incorrect Traversal Links block titles are still showing.

But hopefully this gives you some good additional info. and this can keep moving forward. I'll wait to hear back from you on the status and what my next steps should be.

Hello, was taking a look at this. Wasn't able to reproduce, although I am little confused. There isn't a traversal links block, the traversal links are enabled in the book content type display config. Markup for that is preprocessed then sent to book-navigation.html.twig. Seems like yours might be using a twig override or other preprocessing. They look like this ootb (with book olivero)

Hello, thanks for looking into this more. And you are correct that I'm overriding the default "book-navigation.html.twig" and "book-tree.html.twig" files at /web/modules/contrib/book/templates using files with the same names at: /web/themes/custom/custom-dxpr-theme/templates/navigation

My reasons for doing this and the process I used are detailed at: https://www.drupal.org/project/book/issues/3498328 💬 Twig Templates Location and CSS Styling Questions Active

I have also attached the 2 custom twig files here for reference: "dxpr-book-tree-html-twig.txt" and "dxpr-book-navigation-html-twig.txt"
Note: I had to put these in a .txt file format to upload them, hence the slight difference in naming and formatting ...

The main point is that these overrides were working well and looking fine until I upgraded to Book version 2.0.1. So apparently something in this latest version (and also in 2.0.2) isn't playing nicely with the overrides.

Hopefully this is something that can be fixed on the module side, so that it doesn't disrupt my existing and otherwise benign theme overrides.

The twig templates changing can happen in a contrib. If you override them with your own it's assumed you're taking the responsibility to keep your twig up to date with new changes. If you drop you twig and use the one from the module does it work.

Thanks for the reply and additional info. Before answering your question, here is a quick review of where we're at.

The live site is still running the Book 2.0.0 version plus my overrides of the default "book-navigation.html.twig" and "book-tree.html.twig" files. The screenshot "Book-2.0.0-Version" shows what this looks like.

The staging site is up to date with Book 2.0.2, and the "Staging-w-Contrib" screenshot shows what it looks like with the latest book module and my overrides of the default "book-navigation.html.twig" and "book-tree.html.twig" files.

And to answer your question, see "Staging-no-Contrib" for what it looks like after removing my versions of "book-navigation.html.twig" and "book-tree.html.twig" files at /web/themes/custom/custom-dxpr-theme/templates/navigation.

I think you'll agree that the "Staging-no-Contrib" version looks the worst, and so I would not want to revert back to this default scenario.

In the past, the Traversal links header text was pulling the node title for a given Book page and using it there. As such, I'm still expecting this to say "Neon Users Overview" rather than "10" (and note that "10" makes no sense at all).

But now, even without my overrides of "book-navigation.html.twig" and "book-tree.html.twig", it's still showing "10" (rather than "Neon Users Overview"). And so it does seem that there is still a bug here regardless of these twig overrides.