- 🇺🇸United States jhedstrom Portland, OR
I think 🐛 jQuery.once used in views_data_export_auto_download.js, breaking immediate download for batch exports Fixed is somewhat related for D10+.
The patch #8 → from #3347083 🐛 jQuery.once used in views_data_export_auto_download.js, breaking immediate download for batch exports Fixed fixed the issue (tested on 8.x-1.2 and Drupal 10).
I tried #17, and it doesn't really do anything to help. It does work like #14 scenario 4 described, but that already worked.
It doesn't fix any of the scenarios that don't work, as the other scenarios still don't have automatic download. The JS should be included everywhere if needed, and there's plenty of contrib modules that include a library on every page.
https://www.drupal.org/docs/develop/creating-modules/adding-assets-css-j... →
Also, the only way to attach JS to a message would be to modify the twig template, and it would be for all messages: https://api.drupal.org/api/drupal/core%21modules%21system%21templates%21...
So just including on every page is better.
- last update
about 1 year ago 3 pass - @solideogloria opened merge request.
Please review the merge request, which fixes the issue for all the scenarios mentioned in #15.
- last update
about 1 year ago Composer require-dev failure - last update
about 1 year ago 3 pass Here's a patch file with the changes from #22 if you need it
- 🇫🇷France PhilY 🇪🇺🇫🇷 Paris, France
Patch #22/#24 works for me using Scenario 1, views_data_export 8.x-1.3 (with xls_serialization addon) and Drupal 9.5.9
Thanks - Status changed to RTBC
about 1 year ago 2:43pm 29 June 2023 - last update
9 months ago 3 pass - last update
9 months ago 3 pass Hi friends! When I check the available translations, I come across the following:
In my case, when I download the data from a View, I encounter the following message:
"Export complete. Download the file false" id="vde-automatic-download">here if the file is not automatically downloaded."
Upon inspecting the 'views_data_export_auto_download.js' file, I noticed that the file only downloads automatically if the 'downloadEnabled' attribute is set to 'true'.
To address this issue, I made a translation change and modified the message to:
"Export complete. Download the file true" id="vde-automatic-download">here if the file is not automatically downloaded."
Additionally, I included the line $view->element['#attached']['library'][] = 'views_data_export/views_data_export'; in the view to invoke the necessary library.
@Sebastian45 That change was included in patch #24. Did you try using a patch?