jQuery.once used in views_data_export_auto_download.js, breaking immediate download for batch exports

I don't think this JS file is even required anymore? Immediate download functionality works fine without it.

Confirmed simply removing views_data_export_auto_download.js works.

As there's no Drupal 10 specific branch of views_data_export, this will need to be tested on Drupal 9, but it should also work there.

Hmmm are we sure that the automatic download functionality works without this JS. I can't see how it does. Happy to be wrong.

@alexpott I quickly tested it and it seemed to work. Sounds like we're missing some test coverage there though if we can't rely on that green?

+++ /dev/null
@@ -1,19 +0,0 @@
-            location.href = this.href;

Isn't this just reloading the page?

There is definitely no JS test coverage for this.

Isn't this just reloading the page?

It's setting the current URL to the URL in the #vde-automatic-download link, which seems like bad UX anyway? Looking into it those links are set in a message in DataExport::finishBatch. I didn't test auto download with batch processing so I guess that's where it's needed

Confirmed it is needed for the immediate download batch functionality. New patch fixes the JS instead, no tests yet.

I think we can do a test in a follow-up issue if somebody can manually test #8.

The patch #8 fixed the issue (tested on 8.x-1.2 and Drupal 10).

Thanks all!

Automatically closed - issue fixed for 2 weeks with no activity.