The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
almost 2 years ago 7:41am 7 February 2023 The last submitted patch, 62: 2835545-62.patch, failed testing. View results →
- Status changed to Needs work
almost 2 years ago 9:09am 7 February 2023 - 🇮🇳India bhanu951
core/modules/workflows/src/WorkflowStateItemInterface.php
core/modules/workflows/src/WorkflowStateFieldItemList.php
core/modules/workflows/src/Plugin/Field/FieldType/WorkflowStateItem.phpFiles are missing in #62 which were present in #54.
@Akhil Yadav This is the 6th patch I have looked into today which were re-rolls made by you, missing changes from earlier patches.
It is advised to include interdiff for your re-rolls.
Hiding patch in #62
- Merge request !3400Issue #2835545: Provide a Workflow FieldType that references a workflow entity and tracks the current state of an entity → (Open) created by bhanu951
- 🇮🇹Italy apaderno Brescia, 🇮🇹
There is too much difference between a 15.67 KB patch and a 2.9 KB patch. On Drupal.org, re-rolling a patch to only provide part of the changes is not helpful.
- Status changed to Needs review
almost 2 years ago 2:03pm 9 February 2023 - Status changed to Needs work
almost 2 years ago 7:25pm 2 March 2023 - 🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
Removing credit for patch #62 as it removed almost the entire patch it was rerolling.
Looking at MR 3400 believe the issue summary should be updated to include that the proposed solution to add an interface, hooks, etc now vs just a new fieldtype. Should include probably a why too?
This will 100% require a change record as well.
Left a few small change requests in the MR.
- 🇮🇳India bhanu951
Changed Target Branch to 11.x and updated latest changes as patch for backup before target branch change.