Split the workspaces UI into a separate module

While #2 is a desirable goal, I think the module needs to gain more real-world usage before we can consider moving it to be core API. For now, splitting the UI bits is an easier lift.

We should open a follow-up to move more of the UI scaffolding code over but I like doing the absolute minimum here.

I added a change record. Tagging for release highlights too.

Looks like just the hook_help generic test coverage is the problem now?

Added the release note.

Looks like just the hook_help generic test coverage is the problem now?

Yep, and I've already spent way too many hours last night trying to figure out what the problem is. The hook is there, I can access the help page in the UI on my local, but inside the test this line from \Drupal\help\Controller\HelpController::helpPage() returns FALSE:

if ($this->moduleHandler()->hasImplementations('help', $name)) {

Did you try using a procedural hook_help() implementation?

Yup, I only moved it to an OO hook hoping it would fix stuff, but it didn't.

Opened the followup.

As a core product manager I think this makes sense. It allows us more flexibility in the future to possibly remove the big UI for example from core if we think its not an 80% use case even if content moderation or node preview is.

Only minor note is the description of the original module now does not reflect what it does? The module does not provide full site previews after this MR.

Allows users to stage content or preview a full site by using multiple workspaces on a single site.

This is minor IMHO but would be still useful to fix to make it easier to understand what's the relation between the two modules. But leaving needs review for more reviews as appropriate.

Allows users to stage content or preview a full site by using multiple workspaces on a single site.

Change to maybe this?

Provides an API for staging and previewing content in a full site context.

The suggestion from #27 sounds great, pushed it to the MR.

RTBC

The approach makes sense to me. It feels a little bit weird to have workspace tests need to enable workspaces_ui but for integration tests the UI is obviously needed.

But one curious observation:

Why don’t I see removals of the new Hooks added to workspaces_ui to support toolbar, etc.

I had expected a big removal from workspaces.module, but there is nothing.

Maybe that is related to the hook_help problem?

amateescu → changed the visibility of the branch 2972622-split-workspaces_ui to hidden.

amateescu → changed the visibility of the branch 2972622-split-workspaces_ui to active.

Why don’t I see removals of the new Hooks added to workspaces_ui to support toolbar, etc.

That was because of 📌 [ignore] Convert everything everywhere all at once Active , fixed in https://git.drupalcode.org/project/drupal/-/merge_requests/10147/diffs?c...

catch → credited lauriii → .

Thanks this looks good, nice catch on the moved toolbar hook implementation.

Committed/pushed to 11.x and cherry-picked to 11.1.x, thanks!

catch → closed merge request !10147

Automatically closed - issue fixed for 2 weeks with no activity.