- Assigned to amateescu
- Status changed to Needs work
almost 2 years ago 2:39pm 16 January 2023 - Status changed to Needs review
almost 2 years ago 3:46pm 20 January 2023 - Status changed to Postponed
over 1 year ago 5:16pm 20 March 2023 - π·π΄Romania amateescu
I moved the handling of initial revisions to π Creating an unpublished entity in a workspace does not set the workspace field on the revision Fixed , and this is the remaining part that needs to be done this issue. Postponing on π [PP-1] Prevent content from being deleted when there is an active workspace Postponed .
- Status changed to Needs review
over 1 year ago 12:31pm 2 May 2023 - last update
over 1 year ago 29,370 pass - Status changed to RTBC
over 1 year ago 7:00pm 19 May 2023 - last update
over 1 year ago Patch Failed to Apply - πΊπΈUnited States smustgrave
Tested this one following the issue summary
Logged in as user with the ability to delete but not bypass access
Switched to stage workspace.
Verified the delete button is no there.
Tried to use bulk delete but got This form can only be submitted in the default workspace.
Created a page
Verified I can delete in that workspace - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - Status changed to Needs work
over 1 year ago 4:34pm 12 June 2023 - π·π΄Romania amateescu
Decided to reroll this patch against π Add mechanism to have workspaces skip processing entity types Needs work because the new
isEntityDeletable()
method makes more sense in the context of theWorkspaceInformation
service added there rather than adding it toWorkspaceAssociation
. Leaving at NW for the static caching mentioned in #61. - Status changed to Postponed
over 1 year ago 2:23pm 15 August 2023 - π·π΄Romania amateescu
The way we were altering the entity delete form in this patch doesn't work anymore since delete forms are now opened in a modal. Fixed that by using a service decorator for the entity form controller, and also increased test coverage to also cover the entity access alter.
#62 still applies, so leaving postponed and not bothering with a MR yet until the dependency gets fixed.
- π·π΄Romania amateescu
Added back the static cache in the workspace association service. Converting this patch to a MR next :)
- π·π΄Romania amateescu
amateescu β changed the visibility of the branch 11.x to hidden.
- π·π΄Romania amateescu
amateescu β changed the visibility of the branch 3092247-prevent-content-from to hidden.
- Issue was unassigned.
- Status changed to Needs review
9 months ago 2:56pm 4 March 2024 - π·π΄Romania amateescu
- Status changed to Needs work
8 months ago 2:57pm 8 March 2024 - Status changed to Needs review
8 months ago 9:10am 11 March 2024 - Status changed to RTBC
8 months ago 6:28pm 11 March 2024 - πΊπΈUnited States smustgrave
Feedback appears to be addressed
Ran test-only feature and test coverage is present https://git.drupalcode.org/issue/drupal-3092247/-/jobs/1037544
Applying the MR
Created content in my main space
Switched to a new one and couldn't delete that first node.
But I was able to delete content I crreated in workspace B.Issue summary seems clear about the changes being made.
- Status changed to Fixed
8 months ago 10:40am 12 March 2024 - π¬π§United Kingdom catch
This is looking really good, couldn't find anything to complain about. Committed/pushed to 11.x and 10.3.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.