Make the moderation control form an entity form so that it validates entities before save

smustgrave → credited kevin.vanbelle@skynet.be → .

Closed 🐛 Content moderation revision log should be a textarea as on node edit forms Closed: duplicate as a duplicate

FYI, patch in #81 still applies cleanly to 10.0.9 and works as expected.

Unless otherwise noted and tests fail, here is an attempted reroll from #81 to D10.3.

The log message field might have a different name e.g. in media it is revision_log_message. Meaning either we get the log message field name using $this->entity->getEntityType()->getRevisionMetadataKey('revision_log_message'); or in entity-moderation-form.html.twig we just output the form elements using original entity form keys. However the later doesn't ensure existing form alter will continue to work.

Here are new patches for D10.2 and D10.3 that remove the piece of code that shuffles the form elements around into their respective original keys and instead use the keys from the entity form itself in the template entity-moderation-form.html.twig... However, I am not sure how I could handle the BC here.

Screenshot with the new patch:

Yes, @msnassar. Worked like a charm.

Thanks for this patch. Works with Drupal 10.3.1 and also fixes another inconsistency:

Changing the workflow state on latest revision tab, stores the timestamp of the former revision in node_field_revision and the timestamp of the actual change only in node_revision whereas both timestamps are identical and correspond with the time of the actual change, if the revision has been saved on the add/edit form and the entity implements \Drupal\Core\Entity\EntityChangedInterface.