Menu link content changes are not visible on non-live workspaces

This is just a reroll of the patch from #66 that applies on top of other recent patches from the workspaces issue queue.

@s_leu #73: you're right, that particular override is not necessary anymore. It has been been carried over since the initial patches posted in this issue, but it was made redundant by the override of \Drupal\workspaces\WorkspacesMenuTreeStorage::loadTreeData(), where we ensure that we cache menu trees by workspace.

Like #76, I also couldn't reproduce the problem from #72, my guess is that there was another contrib or custom module at play.

@i-grou #78: new menu links created in a workspace are working correctly (displayed when the workspace is active, not displayed in Live), and there's also test coverage for this in the patch.

Let's get a fresh test run, it's been a few years since the last one.

Also cleaned up the IS a bit, it now describes very well what this patch does.

Can we get a change record for the new service?

Rest looks good.

@smustgrave, do you mean the new workspaces.menu.tree_storage decorator? If so, that's a private service and no one should know (or care) about it :)

Then in that case lets see if we can get into 10.2 early

The last submitted patch, 81: 3040258-81.patch, failed testing. View results →

The last submitted patch, 81: 3040258-81.patch, failed testing. View results →

The last submitted patch, 81: 3040258-81.patch, failed testing. View results →

Two minor nits, please self RTBC after making these changes @amateescu - and feel free to ping me to come back, want to get this in early for 10.2

1. +++ b/core/modules/workspaces/src/WorkspacesMenuTreeStorage.php
   @@ -0,0 +1,112 @@
   +  /**
   +   * The workspace manager service.
   +   *
   +   * @var \Drupal\workspaces\WorkspaceManagerInterface
   +   */
   +  protected $workspaceManager;
   +
   +  /**
   +   * The workspace association service.
   +   *
   +   * @var \Drupal\workspaces\WorkspaceAssociationInterface
   +   */
   +  protected $workspaceAssociation;
   +
   +  /**
   +   * The entity type manager.
   +   *
   +   * @var \Drupal\Core\Entity\EntityTypeManagerInterface
   +   */
   +  protected $entityTypeManager;
   

   Let's use constructor property promotion for new code

2. +++ b/core/modules/workspaces/tests/src/Functional/WorkspaceMenuLinkContentIntegrationTest.php
   @@ -0,0 +1,119 @@
   + * Tests a complete deployment scenario across different workspaces.
   

   copy paste?

Thanks for the review, fixed both points :)

Fixed the doxygen as well.

Issue credits

Committed 96ac98b and pushed to 11.x. Thanks!

As this is limited to the experimental workspaces module, backported to 10.1.x

Automatically closed - issue fixed for 2 weeks with no activity.