The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India nikhil_110
Attached patch against Drupal 10.1.x
Patch #34 is not applied for Drupal 10.1.x so Inter-diff file is not added.
Checking patch core/lib/Drupal/Core/Field/Plugin/Field/FieldFormatter/StringFormatter.php... Hunk #1 succeeded at 178 (offset -3 lines). Checking patch core/modules/field/tests/src/Kernel/String/StringFormatterTest.php... Checking patch core/modules/system/tests/modules/entity_test/entity_test.routing.yml... Hunk #1 succeeded at 55 (offset -13 lines). Checking patch core/modules/system/tests/modules/entity_test/src/Controller/EntityTestController.php... Checking patch core/modules/system/tests/modules/entity_test/src/Entity/EntityTestRev.php... error: while searching for: * "delete-multiple-form" = "/entity_test_rev/delete_multiple", * "edit-form" = "/entity_test_rev/manage/{entity_test_rev}/edit", * "revision" = "/entity_test_rev/{entity_test_rev}/revision/{entity_test_rev_revision}/view", * } * ) */ error: patch failed: core/modules/system/tests/modules/entity_test/src/Entity/EntityTestRev.php:44 error: core/modules/system/tests/modules/entity_test/src/Entity/EntityTestRev.php: patch does not apply Checking patch core/modules/views/config/schema/views.field.schema.yml... Checking patch core/modules/views/src/EntityViewsData.php... Hunk #1 succeeded at 267 (offset 3 lines). Checking patch core/modules/views/src/Plugin/views/field/LinkToLatestRevision.php... - Status changed to Needs review
over 1 year ago 9:25am 6 April 2023 - Status changed to Needs work
over 1 year ago 5:01pm 6 April 2023 - 🇺🇸United States smustgrave
This could use an issue summary update. What is the proposed solution? Api changes? What is remaining? That would be a good start to help move this issue forward.